On Mon, 15 Apr 2024 13:23:22 GMT, Suchismith Roy <s...@openjdk.org> wrote:
>> Allow support for both .a and .so files in AIX. >> If .so file is not found, allow fallback to .a extension. >> JBS Issue: [JDK-8319516](https://bugs.openjdk.org/browse/JDK-8319516) > > Suchismith Roy has updated the pull request incrementally with one additional > commit since the last revision: > > Files copy I think it's good. I only found minor nits. test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java line 57: > 55: // // launch a java application which calls System.loadLibrary > and is passed > 56: // // the directory containing the native library archive file, > through > 57: // // -Djava.library.path Please avoid `// //`. test/jdk/java/lang/RuntimeTests/loadLibrary/aix/LoadAIXLibraryFromArchiveObject.java line 71: > 69: } > 70: } > 71: } I think files typically have a newline at the end. ------------- PR Review: https://git.openjdk.org/jdk/pull/17945#pullrequestreview-2001218422 PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1565859302 PR Review Comment: https://git.openjdk.org/jdk/pull/17945#discussion_r1565860272
