On Tue, 7 May 2024 13:36:55 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/floatingpoint/TestRoundFloatAll.java line 31: >> >>> 29: * @library /test/lib / >>> 30: * @modules java.base/jdk.internal.math >>> 31: * @run main/othervm -XX:-TieredCompilation >>> -XX:CompileThresholdScaling=0.3 -XX:+PrintIdeal >>> -XX:CompileCommand=compileonly,compiler.floatingpoint.TestRoundFloatAll::test* >>> -XX:-UseSuperWord compiler.floatingpoint.TestRoundFloatAll >> >> please break up the line for easier reading > > Why these flags: > `-XX:-TieredCompilation -XX:CompileThresholdScaling=0.3 -XX:+PrintIdeal > -XX:-UseSuperWord` ? > > I also suggest that you use `-Xbatch`, just to make sure we have compiled all > relevant methods after the warmup. If things get too slow, then maybe you > want to consider using explicit compile exclusion / forbidding inlining for > the `test*` method, rather than the compileonly, which prevents everything > else from compiling. Thanks for suggestion, added `-Xbatch`. removed `-XX:+PrintIdeal`. keep `-XX:-UseSuperWord`, as we are testing scalar version intrinsic in this test. `-XX:-TieredCompilation -XX:CompileThresholdScaling=0.3` are just from previous tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17753#discussion_r1592837993
