On Wed, 15 May 2024 11:34:37 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> applied the suggested changes > > src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java > line 308: > >> 306: 0; >> 307: default -> >> 308: -1; > > I recommend we explicitly return -1 to skip verification only for > UnknownAttribute and CustomAttribute; then our tests can catch missing > verification for new attribute additions. There are still many attributes missing here (yet). However it is a nice goal. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16809#discussion_r1604550145
