On Sun, 12 May 2024 08:36:44 GMT, Chen Liang <li...@openjdk.org> wrote:
> Some tests are not migrated to the ClassFile API in previous migrations. > > - Some are simple oversights that didn't remove usages of > com.sun.tools.classfile; > - The CallerSensitive ones used an old utility, replaced by CF API-based new > code; > - many in javac are because the files are compiled with older source > compatibility. Those patches are converted to have the source code stored in > text blocks and compiled within tests using `ToolBox#writeJavaFiles` and > `CompilerUtils.compile`; > - As described in the JBS issue, there are a few other tests not covered; > one is in #19193 while the others are blocked by CreateSymbols migration or > bugs. > > Testing: all modified tests pass. This pull request has now been integrated. Changeset: beeffd46 Author: Chen Liang <li...@openjdk.org> Committer: Adam Sotona <asot...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/beeffd4671649e5d8f9c96f0455ac90a82917234 Stats: 1539 lines in 19 files changed: 224 ins; 1098 del; 217 mod 8332109: Convert remaining tests using com.sun.tools.classfile to ClassFile API Reviewed-by: asotona ------------- PR: https://git.openjdk.org/jdk/pull/19206
