See attached. Perhaps we should also print a post code if the SMBus
controller can't be found - suggestions for a value?

Thanks,
Ward.

-- 
Ward Vandewege <w...@fsf.org>
Free Software Foundation - Senior Systems Administrator
We can't print this early.

This patch fixes a hang on 

  supermicro/h8dme
  supermicro/h8dmr
  supermicro/h8dmr_fam10

and possibly on other mcp55-based boards.

Signed-off-by: Ward Vandewege <w...@gnu.org>

Index: src/southbridge/nvidia/mcp55/mcp55_early_smbus.c
===================================================================
--- src/southbridge/nvidia/mcp55/mcp55_early_smbus.c	(revision 6011)
+++ src/southbridge/nvidia/mcp55/mcp55_early_smbus.c	(working copy)
@@ -32,11 +32,8 @@
 	device_t dev;
 	dev = pci_locate_device(PCI_ID(0x10de, 0x0368), 0);
 
-	if (dev == PCI_DEV_INVALID) {
-		printk(BIOS_WARNING, "SMBUS controller not found\n");
-	} else {
-		printk(BIOS_DEBUG, "SMBus controller enabled\n");
-	}
+	if (dev == PCI_DEV_INVALID)
+		die("SMBus controller not found\n");
 
 	/* set smbus iobase */
 	pci_write_config32(dev, 0x20, SMBUS0_IO_BASE | 1);
-- 
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to