On 2018-04-03 10:02, Aaron Durbin via coreboot wrote:
On Tue, Apr 3, 2018 at 10:26 AM, <mtur...@codeaurora.org> wrote:
Folks,
Can anyone on this list expound on why VbTryLoadKernel() performs a
sanity-check on bytes_per_lba != 512?
------->-------/*
------->------- * Sanity-check what we can. FWIW, VbTryLoadKernel() is
always
------->------- * called with only a single bit set in get_info_flags.
------->------- *
------->------- * Ensure 512-byte sectors and non-trivially sized disk
(for
------->------- * cgptlib) and that we got a partition with only the
flags we
------->------- * asked for.
------->------- */
Seems to do with cgptlib having a 512 byte assumption. I'm not sure
what would break if that check was removed. We'd have to look at
cgptlib and other uses. Please file a Google issue tracker bug so we
can properly drive this.
https://issuetracker.google.com/77540192
We are working on supporting a board that will require bytes_per_lba
== 4K.
Cheers,
T.mike
--
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot
--
coreboot mailing list: coreboot@coreboot.org
https://mail.coreboot.org/mailman/listinfo/coreboot
