On Sun, Apr 7, 2013 at 10:44 PM, Jakub Wilk <jw...@debian.org> wrote: > (I don't intend to sponsor this. Sorry!)
Thanks for the review anyway! > * Dmitry Shachnev <mity...@gmail.com>, 2013-04-07, 16:48: > >>> FTR, the repository is here: >>> svn://anonscm.debian.org/pkg-fonts/packages/woff-tools/trunk >>> >>> Please fix the Vcs-Svn field. :) >> >> >> Done, thanks! I should probably have mentioned it when I was filing the >> bug… > > > Who was .orig.tar created? You can answer in README.source or by writing > get-orig-source target. :) Added get-orig-source. > cppcheck says: > [woff.c:281]: (error) Common realloc mistake: 'woffData' nulled but not > freed upon failure > [woff.c:301]: (error) Common realloc mistake: 'woffData' nulled but not > freed upon failure I’ll report a bug to Mozilla, but I don't think it’s worth a downstream patch. > lintian should have emitted hyphen-used-as-minus-sign, but for some reason > didn't... Fixed, thank you! > According to man-pages(7), the DESCRIPTION sections should be between > SYNOPSIS and OPTIONS. It also advices against the AUTHOR(S) section. Fixed. > The package description and manual pages mention only OpenType fonts, but > upstream homepage says TrueType fonts are supported too. The manpages are based on output of upstream “-h” option, which only says about OpenType. The code also doesn’t mention TrueType, so I would prefer to keep my current descriptions. -- Dmitry Shachnev -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org