clone #750497 -1
retitle -1 mate-menus fails to execute due to Debian/Hurd patch (see #750497)
severity -1 grave
thanks


Hi Adam,

On  Mi 04 Jun 2014 01:07:21 CEST, Adam Borowski wrote:

I'm afraid this patch doesn't work.  It makes the code compile, but if you
try to execute it, it will assume any symlinks form a loop.

The relevant snippet is:
                                if (++num_links > MAXSYMLINKS)
                                {
                                        errno = ELOOP;
                                        goto error;
                                }
which fails to execute if the returned value is -1.  Linux' headers use an
arbitrary bogus value of MAXSYMLINKS 20 to let old code work, Hurd guys
decided that it's better for wrong code to fail at compilation stage.
It's the same story as MAX_PATH.

sysconf(_SC_SYMLOOP_MAX) returns -1 on Linux as well.

with so much background knowledge on this, do you think you can provide a patch for the patch?

Should we simply set MAXSYMLINKS to this value of 20 instead?

Thanks,
Mike
--

DAS-NETZWERKTEAM
mike gabriel, herweg 7, 24357 fleckeby
fon: +49 (1520) 1976 148

GnuPG Key ID 0x25771B31
mail: mike.gabr...@das-netzwerkteam.de, http://das-netzwerkteam.de

freeBusy:
https://mail.das-netzwerkteam.de/freebusy/m.gabriel%40das-netzwerkteam.de.xfb

Attachment: pgpuRsGXkV2mb.pgp
Description: Digitale PGP-Signatur

Reply via email to