Osamu Aoki <osamu_aoki_h...@nifty.com> writes: > Hi, > > Your suggestion of enhancement is good one.
Thank you :-). > > On Sat, Jun 21, 2014 at 01:52:52PM +0530, Vasudev Kamath wrote: >> debmake -a ~/Downloads/fantasque-sans-1.6.4.orig.tar.gz -b data >> >> and was expecting it to extract upstream tarball and form package >> instead I got this error >> >> E: Non-supported tarball name >> /home/vasudev/Downloads/fantasque-sans-1.6.4.tar.gz > > Yah... I assumed to use the current directory. I see, I thought so.. > >> I checked the source and its raising from debmake.sanity module, this is >> happening because regex only matches the package name, which is right >> but para['tarball'] should only contain the tarball name, i.e. we should >> apply os.path.basename on args.archive before assigning it to >> para['tarball']. > > As I reread my code, I copy the tarball to the current directory with > preprocessing (# remote URL). Yeah noted that, so first I thought of fixing para['tarball'] but later noticed the processing of remote URL so skipped it process the para['tarball'] in place. > > So adding one more preprocessing for tarball value including '/' to copy > tarball from remote directory to the current directory and drop > preceding path in the para['tarball'] may be consistent with other > parts. Yeah that makes sense. > > I also copy tar in dist.py to the root of the source tree to keep > package-1.0/ and package.tar.gz in the same location. Probably better to move it to sanity.py to do it right? -- Vasudev Kamath http://copyninja.info Connect on ~friendica: copyni...@samsargika.copyninja.info IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net} GPG Key: C517 C25D E408 759D 98A4 C96B 6C8F 74AE 8770 0B7E
signature.asc
Description: PGP signature
