Hey there,
On Sep 6, 2014 6:03 AM, "Holger Levsen" <hol...@layer-acht.org> wrote:
>
> Hi Marcos,
>
> On Freitag, 5. September 2014, Marcos Marado wrote:
> > Sure, here it is:
> >
> >
https://github.com/marado/html2text/commit/2e7b95138bb932261fed0863d2d28058
> > cfdacaa3
>
> great, thanks! Some remarks/questions:
>
> 900-complete-utf8-entities-table.patch modifies the Makefile, this seems
> unneccesary, can you fix this, please?

Yes, I noticed that after I sent you the link, please look at the latest
version of that patch, instead of looking into the commit.

> And why modify tests/pkgreport.html.supposed at all?

Well, if you see the patch for 'supposed' you'll notice that it actually
has stuff like &quot;this&quot; , when it should be "this".

Cheers,

>
> cheers,
>         Holger

-- 
Marcos Marado

Reply via email to