control: tags -1 patch > So now we know, that 4:4.13.3-1 is the last known good package and > 4:4.14.0-1 the first known bad package. We also know, that saving, not > loading the session really is the problem. > So there seems to be another idea needed to further debug the problem. As all 5 packages come from the same source package (according to https://packages.qa.debian.org/k/kde-baseapps.html), I downloaded this package in both versions with > debsnap kde-baseapps 4:4.14.0-1 > debsnap kde-baseapps 4:4.13.3-1 unpacked the archives and looked with kdiff3 for interesting changes.
One interesting change is inside of
> kde-baseapps-4.1?.?/konqueror/src/konqmainwindow.cpp
in lines 5193 until 5196, where effectively
> if (isPreloaded() && !kapp->sessionSaving()) {
> hide();
> }
is changed into
> if (stayPreloaded() && !kapp->sessionSaving()) {
> e->ignore();
> hide();
> }
Thus, the main window's close event gets ignored (whatever that means) and
the condition is changed from isPreloaded to stayPreloaded. So preloading
might be involved into this bug.
I just checked my Konqueror settings and my background process
configuration is "2", "no", "no". I changed it to "3", "yes", "yes", but this
does not change nor fix the session management behavior with 4:4.14.0-1.
Here goes nothing! I should be able to build the package myself so
that I can test changes. To get the build dependencies, I executed
> apt-get build-dep kde-baseapps
which installed some development packages and downloaded the most recent
version with
> apt-get source kde-baseapps
I can now build the packages by using
> cd kde-baseapps-4.14.1; fakeroot dpkg-buildpackage -j6 -b -uc -us
After reverting the change above in 4:4.14.1.1, rebuilding the package and
installing it, Konqueror's session management works again.
For the record, this is the diff between the working and the breaking commit:
https://projects.kde.org/projects/kde/applications/kde-baseapps/repository/diff/konqueror/src/konqmainwindow.cpp?rev=0f149f4469677e8c830962c748fca4d5aa2fbf9e&rev_to=af5a796edddefb08f9d7c02068a6e891a327b25a
The commit message
> Port away from queryExit().
> stayPreloaded() already checks whether this is the last window.
already sounds as this has not been the best commit, as you can't port away
from something, which is already commented or unused code.
Dear maintainer, please revert this commit and upload the changed packages.
Kind regards
Patrick
signature.asc
Description: This is a digitally signed message part.
