Control: tag -1 - patch + newcomer Hi Kai-Chung,
On Tue, Jul 28, 2015 at 2:51 AM, 殷啟聰 <seamli...@gmail.com> wrote: > Source: f2fs-tools > Version: 1.4.1-1 > Severity: wishlist > Tags: patch > X-Debbugs-CC: > komaldsukh...@gmail.com,h...@at.or.at,a...@gambaru.de,android-tools-de...@lists.alioth.debian.org > > Hi, > > I am packaging Android SDK which requires a libf2fs_fmt.so compiled > from libf2fs.c, f2fs_format.c and f2fs_format_utils.c. Android SDK > also needs the headers of f2fs-tools. More information can be found at > <https://android.googlesource.com/platform/external/f2fs-tools/+/master/Android.mk>. > Currently f2fs-tools package does not provide these files for external > development use, so I wish to add a new package "f2fs-tools-dev" > containing some development files. I have made a patch for the > modifications. > > This patch creates a new package "f2fs-tools-dev" and a > f2fs-tools-dev.mk that compiles the source files mentioned above into > 2 .a files. The package installs this 2 .a files and the headers. > Please consider using it, thank you. Thanks for the patch! However, there are a few issues with it that should be fixed before I'd consider uploading it: - Debian Policy 8.4 [1] dictates that header files and static libs should be installed in a binary package named libfoo-dev, not "f2fs-tools-dev" (I'd suggest libf2fs-dev here). At the same time I suggest splitting out the shared library currently installed in f2fs-tools into its own package, e.g. libf2fs0. - Both libf2fs-dev and libf2fs0 should be multiarch-ified by installing files into the appropriate multiarch paths and including the appropriate multiarch fields in d/control. You can refer to this guide to help you MA-ify a package. [2] - Instead of adding a makefile, please integrate your changes into the autotools setup that f2fs-tools currently uses. Regards, Vincent [1] https://www.debian.org/doc/debian-policy/ch-sharedlibs.html [2] https://wiki.debian.org/Multiarch/Implementation -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org