Christopher James Halse Rogers:
> Thanks for the patches! I'll add the necessary autofoo checks and propose
> them upstream.

Great! :)

Do you have any contacts with lcms2 upstream? Because I guess they would
need to accept the required patch as well before it makes sense to write
such a test. It's a pretty straight forward patch, so I really hope it
will be an easy one to get in.

> Would it make more sense for cd-it8 to also respect SOURCE_DATE_EPOCH? Is
> there a reason other than ‘it was simpler to just disable timestamps’
> (before I try duplicating the cd-create-profile logic into that patch).

cd-it8 is the first thing that I've patched to try to get colord
reproducible, so I went for the easiest path. I discovered later that
the creation date/time was mandatory for ICC profiles, so I implement
full SOURCE_DATE_EPOCH logic there. You feel it's more coherent to do
the same in cd-it8, please port it there! :)

-- 
Lunar                                .''`. 
lu...@debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   

Attachment: signature.asc
Description: Digital signature

Reply via email to