Done [1] and done [2]. Graham, you might want to subscribe to those PRs. Cheers, Nico
[1] https://github.com/kokkos/kokkos/pull/57 <https://github.com/kokkos/kokkos/pull/576>5 [2] https://github.com/kokkos/kokkos/pull/576 On Fri, Dec 9, 2016 at 11:22 AM Graham Inggs <gin...@debian.org> wrote: > On 9 December 2016 at 09:49, Nico Schlömer <nico.schloe...@gmail.com> > wrote: > > The patch looks really simple. Great! Do you think it'd be worthwhile > > updating the PR [1] (or opening a new one)? Perhaps the kokkos devs can > > figure out why the remaining tests are failing. > > No harm in trying, I guess. :) > Please update the PR, but I suggest leaving out the static_asserts, > i.e. don't include the changes to Kokkos_Core_fwd.hpp and > Kokkos_TaskQueue.hpp. > Also, I think the changes to Kokkos_Macros.hpp from > kokkos-disable-asm.patch should go in a separate PR. Hopefully they > can merge that right away. >