On Sat, Feb 11, 2017 at 05:29:06PM +0000, Neil Williams wrote: > On Sat, 11 Feb 2017 17:10:16 +0100 > Guido Günther <a...@sigxcpu.org> wrote: > > > Hi Neil, > > On Tue, Jul 05, 2016 at 08:39:23PM +0200, Guido Günther wrote: > > > Control: tags -1 moreinfo > > > > > > On Wed, May 18, 2016 at 10:07:22AM +0100, Neil Williams wrote: > > > > This is an error in the version string in debian/changelog but > > > > git-buildpackage produces a confusing error string when if I use > > > > git-archive and then debuild, I get a much more useful error > > > > message: > > > > > > > > dpkg-source -b 2016.4.post1 > > > > dpkg-source: error: can't build with source format '3.0 (quilt)': > > > > non-native package version does not contain a revision > > > > > > > > To fix this bug, git-buildpackage should reproduce this error > > > > message instead of failing with a NoneType. > > > > > > In 0.8.0 I get: > > > > > > $ gbp buildpackage --git-ignore-new --git-no-pristine-tar > > > --verbose gbp:error: Can't determine upstream version from changelog > > Reproducing the problem locally, I get: > debconf-updatepo > make[1]: Leaving directory '/home/neil/code/lava/packaging/alioth/lava-server' > dh_clean > gbp:info: Tarballs 'lava-server_None.orig.tar.gz' not found at '../tarballs/' > gbp:error: Can't determine upstream version from changelog > > $ cat debian/gbp.conf > [DEFAULT] > overlay = True > pristine-tar = False > > $ dpkg-parsechangelog > Source: lava-server > Version: 2017.3 > Distribution: unstable > Urgency: medium > Maintainer: Neil Williams <codeh...@debian.org> > Timestamp: 1486833306 > Date: Sat, 11 Feb 2017 17:15:06 +0000 > Changes: > lava-server (2017.3) unstable; urgency=medium > . > * test release > > So gbp is still picking up a NoneType as the version - IMHO it should > fail immediately at that point and not even try to find > package_None.orig.tar.gz. NoneTypes are a pythonism, as is the ability > to turn a NoneType into the 'None' string. > > The error: > gbp:error: Can't determine upstream version from changelog > > is not as clear as the original message:
But it's not wrong either. > > > > > dpkg-source: error: can't build with source format '3.0 (quilt)': > > > > non-native package version does not contain a revision > > > > > Which looks closer to this. Could you check if it's the same for > > > you? If not please show me your > > > > > > gbp config buildpackage > > > > > > (run from within the repo). > > > > > > BTW I looked at the lava-server repo but couldn't find the Debian > > > branch. > > https://github.com/Linaro/pkg-lava-server - as linked from the PTS and > debian/control file. > > Also mirrored here: > https://anonscm.debian.org/cgit/pkg-linaro-lava/lava-server.git/ > > > Since I failed to repoduce this. Can you still? If so can you give > > further instructions how? Otherwise I'm inclinded to close it as I > > have no way to fix it either. > > The fix is to always check for a NoneType - there is no reason for a > python program to look for foo_None.bar on a filesystem. At absolute > worst it should be foo_.bar After more fiddling I'm now able to reproduce this: git clone https://github.com/Linaro/pkg-lava-server cd pkg-lava-server sed -i -e 's/2017.2-1/2017.1/' debian/changelog git commit -m"Break changelog" -a gbp buildpackage --git-export-dir=../b --git-tarball-dir=../tarballs
