One additional patch required: the previous version built fine locally in a terminal, but when dispatched to a builder, the build failed because the test suite is testing functions that only output anything when stdin is a tty. Since this is clearly deliberate behavior in the code, I'm updating the test suite to match.
Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
Description: skip usage() tests on autobuilders The usage() functions check whether stdin is a tty before displaying usage information. Therefore, we should not test this code when running on an autobuilder without a tty. . Clever allocation of a pty from within the test suite itself for purposes of testing this path is left as an exercise for the reader. Author: Steve Langasek <steve.langa...@canonical.com> Index: python-pysam-0.11.2.2/tests/samtools_test.py =================================================================== --- python-pysam-0.11.2.2.orig/tests/samtools_test.py +++ python-pysam-0.11.2.2/tests/samtools_test.py @@ -245,6 +245,7 @@ self.check_statement(statement) @unittest.skipIf(sys.platform == "darwin", "not supported, pattern does not match") + @unittest.skipIf(not sys.stdin.isatty(), "skipping usage tests, stdin is not a tty") def testUsage(self): if self.executable == "bcftools": # bcftools usage messages end with exit(1)
signature.asc
Description: PGP signature