On Mon, 05 Feb 2018 00:10:21 +0100, Mattia Rizzolo wrote: > > Very quick visual check: All I've seen use dh_auto_test, either with > > some variables or with some actions before or after. > If there are actions before or after dh_auto_test then it may still be > "unsafe":
Yes, they may, or they may not. Second cursory visual check: Mostly `mkdir -p $(BUILDHOME)'. Some `mv file file.bak' before and the opposite afterwards. A `chmod' or two of an existing file. Ok, +/- 2 hardcoded `make test'. 2 hits for over 300 false positives sound like there's room for improvement. > I've seen package running `make -C test` before dh_auto_test, > that one should be skipped if DEB_BUILD_OPTIONS=nocheck. Ack. > Or that try to move some test artifact after dh_auto_test: that would > actually cause a ftbfs if dh_auto_test did nothing. Yup, I've seen this in other packages. > The only "safe" cases of command that are fine to run in an > override_dh_auto_test are : and echo (if not redirected to a file). Here I disagree. Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `- NP: Tom Waits: Georgia Lee
signature.asc
Description: Digital Signature
