On 2018-02-06 23:01, Nicholas D Steeves wrote: > On Tue, Feb 06, 2018 at 04:02:07PM -0500, Sandro Tosi wrote: >> patch is welcome, NMU is not; feel free to upload the patch to this bug >> and i'll take care of the upload. thanks for working on this Debian bug > > That's fair. The main thing I'd like to avoid is the autoremoval of > rdepending packages ;-)
You already reset the timer by keeping the discussion in this bug alive ;-) > I pushed to the following remote and have also > attached the patches (see commit messages for more info): > https://salsa.debian.org/sten-guest/python-regex.git Assuming the next upload will be versioned 0.1.20171212-2, the version in the .maintscript files needs to be 0.1.20171212-2~, i.e. you want "<version-that-introduced-the-correct-dmh-call>"+"~". That version will also be OK if a new upstream release comes with the fix, but not for a NMU (that would be versioned 0.1.20171212-1.1 and you would need to use 0.1.20171212-1.1~ in that case). There is no need to bump the version in the .maintscript files for further uploads to buster (unless you need more bugfixes to the d-m-h calls) (or unless you are uploading new upstream releases to stretch). There are only two cases while upgrading: upgrading from a version without the fix (e.g. stretch or 0.1.20171212-1) or a version with the fix (in that case the migration can be skipped) You should squash the two patches, the separation just causes confusion. regarding the commit message: >Maintscripts had: > symlink_to_dir pathname new-target There is no such thing as a "new-target" for symlink_to_dir. I think the maintscripts had "symlink_to_dir pathname current-package". Andreas PS: I would likely have sponsored a delayed NMU, after several rounds of revision ;-)
