On 06/23/2018 08:42 PM, Santiago Vila wrote: > ====================================================================== > FAIL: > proliantutils.tests.ilo.test_firmware_controller.FirmwareImageUploaderTestCase.test__get_socket_throws_exception_in_case_of_failed_connection_2 > proliantutils.tests.ilo.test_firmware_controller.FirmwareImageUploaderTestCase.test__get_socket_throws_exception_in_case_of_failed_connection_2 > ---------------------------------------------------------------------- > _StringException: Traceback (most recent call last): > File "/usr/lib/python2.7/dist-packages/ddt.py", line 129, in wrapper > return func(self, *args, **kwargs) > File "proliantutils/tests/ilo/test_firmware_controller.py", line 566, in > test__get_socket_throws_exception_in_case_of_failed_connection > self.assertRaises(expected_exception_type, fw_img_uploader._get_socket) > File "/usr/lib/python2.7/unittest/case.py", line 473, in assertRaises > callableObj(*args, **kwargs) > File "/usr/lib/python2.7/unittest/case.py", line 116, in __exit__ > "{0} not raised".format(exc_name)) > AssertionError: IloConnectionError not raised > > [...] > > I admit this is strange because it seems to build ok in the > reproducible builds autobuilders. > > I can even reproduce it with plain dpkg-buildpackage (i.e. without sbuild) > on a brand new machine from Digital Ocean, so if you could not reproduce > this, please contact me privately. As a last resort, I could give you > access to one of such machines. > > Thanks.
Hi Santiago, Thanks for your bug report. This isn't strange at all. What's happening is that it builds fine without external connection. I tried disabling internet connectivity on my laptop to build the package, and it built fine. That's also what happens on the buildd and in the reproducible environment, where probably you do have external connectivity on your builders and on the Digital Ocean machine. What I believe happens is that the test test__get_socket_throws_exception_in_case_of_failed_connection expects connectivity to 1.1.1.1 to fail (as this is the purpose of the test: to check if an exception is raised when connectivity fails), though it doesn't fail, there really is a host behind 1.1.1.1 these days. Probably there wasn't any machine responding to 1.1.1.1 when the package was uploaded. Replacing the IP by 198.51.100.1, which is reserved by IETF for documentation (according to https://en.wikipedia.org/wiki/Reserved_IP_addresses) fixes the issue. I have reported the issue upstream: https://bugs.launchpad.net/proliantutils/+bug/1779342 and I will probably attempt to fix it upstream and in Stretch. Cheers, Thomas Goirand (zigo)