On Fri, Jun 29, 2018 at 3:26 AM Mike Brodbelt <m...@coruscant.org.uk> wrote:
> On 29/06/18 04:26, Felipe Sateler wrote: > > > Thanks. However, it has some flaws that need to be reworked for this to > > work at all: > > > > 1. We can't rely on gcc being installed > > Would "dpkg-architecture -qDEB_BUILD_MULTIARCH" be a reasonable > replacement? > Unfortunately not. It is part of dpkg-dev, which is also not installed by default (and requiring it via pulseaudio doesn't make much sense). I think using /proc/1/comm or /proc/1/exe are better alternatives. > > 2. It doesn't check /proc is actually mounted > > 3. dpkg status check is racy: sysvinit might be upgraded at the same > > time, and thus not be "installed" > > 4. dpkg status check is for the wrong package: sysvinit no longer exists > > (I think you want sysvinit-core). > > 5. The postinst should be the one for libpulse0, not pulseaudio > > Will have a poke at these when I get a minute. > > > You missed the conffile mark because it is shipped in libpulse0 :) > > That would explain that :-) > > > I don't have objections in principle, but I want a good and relatively > > not-risky implementation first. > > Ack. > > > BTW, it might be easier to do the review/fixup dance in a merge request > > on salsa: https://salsa.debian.org/pulseaudio-team/pulseaudio > > OK. Haven't played with that before, but will have a look. > It's not strictly required, but I would prefer that, thanks. -- Saludos, Felipe Sateler
