On Sun, Nov 04, 2018 at 10:19:00AM -0800, James Bottomley wrote: > On Sun, 2018-11-04 at 18:43 +0100, Kurt Roeckx wrote: > > Older versions of openvpn only support TLS 1.0 because they told > > OpenSSL to only use TLS 1.0. Adding the --tls-version-min 1.0 > > should make it support all TLS versions since openvpn 2.3.4 or > > something like that, and I think 2.4 or newer should just work. > > There's a difference: if you don't specify the command line tls- > version-min, it actually asks openssl for the minimum version. If you > do specify, it takes what you tell it.
There is no API in OpenSSL to ask the minimum supported version. What 2.3.4 does is that if you don't specify anything, it tells OpenSSL to use TLS 1.0 only. What 2.4 does it just tell OpenSSL to use any version it supports. You can also specify that minimum version in the config file. > > But if you changed the openssl.cfg to say all versions are > > supported, it should work too, I'm not sure why you say otherwise. > > Well, obviously because it doesn't work as the log attached in the bug > report shows. > > The values I have in openssl.cnf are the recommended > > MinProtocol = None > CipherString = DEFAULT > > And it definitely works because imap has an android client at 0.9.8 > which didn't work before the addition of that. > > The openssl code looks to use SSL_CTX_get_min_proto_version() if you > don't specify a version, so it finds a protocol below tls 1.0 to > present which causes the error. From the ordering in openssl, this is > likely to be SSLv3, isn't it? With the above config SSL_CTX_get_min_proto_version() will return 0 indicating that all version supported at compile time are supported. The minium at compile time is TLS 1.0. > The bug here is that you shouldn't kill the negotiation just because > the client offers to support SSLv3, you should move on to negotiate a > more secure cipher and only error out if the client can't support any > protocols openssl is told to consider secure. This is not at all how the version negiotation in TLS 1.2 and below works. The client just indicates the highest version it supports, so for instance TLS 1.2. It's then up to the server to pick a version that the client supports, so one that is smaller than TLS 1.2, and it might pick TLS 1.0 or 1.2. It will then send a server hello with that version. So there are normally 2 cases that can be a problem: - The client sends TLS 1.0 and the server has 1.2 as minimum, so the server say it's not supported. - The client sends TLS 1.2, the server answers with 1.0, the client says 1.0 is too low. The error message you showed says that it's the server that is rejecting the client's version, and that the server is running a 1.1.1 version. Are you sure you've actually restarted the server after changing the config file? Kurt
