Bug#921607: Please exec the actual mupdf from the shell script

[martin f krafft]

Package: mupdf
Version: 1.14.0+ds1-3
Severity: normal
Tags: patch



--- /usr/bin/mupdf      2019-01-19 16:01:19.000000000 +1300
+++ /usr/bin/mupdf      2019-02-07 17:32:54.678896649 +1300
@@ -42,7 +42,7 @@
trap 'rm -f "$tmp"' EXIT

if [ "$file" = "" ]; then
-    $cmd || true
+    exec $cmd
else
-    $cmd "$file" || true
+    exec $cmd "$file"
fi

--
System Information:
Debian Release: buster/sid
 APT prefers unstable
 APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_NZ, LC_CTYPE=en_NZ.UTF-8 (charmap=UTF-8), LANGUAGE=en_NZ:en 
(charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages mupdf depends on:
ii  libc6            2.28-5
ii  libfreetype6     2.9.1-3
ii  libharfbuzz0b    2.3.0-1
ii  libjbig2dec0     0.15-2
ii  libjpeg62-turbo  1:1.5.2-2+b1
ii  libopenjp2-7     2.3.0-1.1
ii  libssl1.1        1.1.1a-1
ii  libx11-6         2:1.6.7-1
ii  libxext6         2:1.3.3-1+b2
ii  zlib1g           1:1.2.11.dfsg-1

mupdf recommends no packages.

Versions of packages mupdf suggests:
ii  mupdf-tools  1.14.0+ds1-3

--
no debconf information


--
.''`.   martin f. krafft <madduck@d.o> @martinkrafft
: :'  :  proud Debian developer
`. `'`   http://people.debian.org/~madduck
 `-  Debian - when you have better things to do than fixing systems

Currently, a shell script spawns the actual mupdf. If the shell script is killed, it does not take the mupdf process with it. There is also no reason why the shell script needs to stay around. Please use 'exec' as per this patch:

digital_signature_gpg.asc
Description: Digital GPG signature (see http://martin-krafft.net/gpg/sig-policy/999bbcc4/current)