Axel Beckert: > Package: debhelper > Version: 13 > Severity: important > > Hi, > > for switching wdm to compat level 13 I changed debian/rules as follows: > > [...] > > Upon package upgrade, wdm is nevertheless restarted and the currently > running X session is gone. >
Hi Axel, Thanks for reporting this bug. The options are confusingly similar due to an unfortunate choice many years ago. It does not help that the text differs between dh_installinit and dh_installsystemd despite the options intend to have the same meaning. > With a lot of experimenting (e.g. trying the alias --no-stop-on-upgrade > for --no-restart-on-upgrade), I figured out that this works as I want > it: > > ------------------------------------------------------------------------ > override_dh_installinit: > dh_installinit --noscripts > > override_dh_installsystemd: > dh_installsystemd --no-restart-on-upgrade --no-restart-after-upgrade > ------------------------------------------------------------------------ > Can I please have you use "--no-stop-on-upgrade" instead of "--no-restart-on-upgrade". The "on" vs. "after" upgrade is not kind to the eyes when they have different meanings and I intend to remove the "on" variant for exactly this reason. The "no-stop-on-upgrade" is not entirely accurate either though, but at least it is less likely to be misread as "restart". > But the dh_installsystemd(1) man pageIMHO doesn't explain this > behaviour: > > ------------------------------------------------------------------------ > [...] > ------------------------------------------------------------------------ > > "Do not stop service on upgrade." is clearly not true unless additional > options are given. > > "Undo a previous --restart-after-upgrade (or the default of compat 10)." > is not true either there was no previous --restart-after-upgrade to > undo. > > I suspect that either > > * the logic which adds the snippets to postinst is flawed, > * the snippets added to postinst are flawed, or > * it's a pure documentation issue. > > [...] It is the logic, although the documentation was not great either. ~Niels
