Hi,
Thanks for the report. I've found an existing patch upstream for these
pycodestyle violations.
I've packaged the patch in urlwatch-2.18-2 and uploaded the package to
mentors.
Regards,
Maxime
Le dim. 21 juin 2020 à 22:09, Lucas Nussbaum <lu...@debian.org> a écrit :
> Source: urlwatch
> Version: 2.18-1
> Severity: serious
> Justification: FTBFS on amd64
> Tags: bullseye sid ftbfs
> Usertags: ftbfs-20200620 ftbfs-bullseye
>
> Hi,
>
> During a rebuild of all packages in sid, your package failed to build
> on amd64.
>
> Relevant part (hopefully):
> > debian/rules build
> > dh build --with python3 --buildsystem=pybuild
> > dh_update_autotools_config -O--buildsystem=pybuild
> > dh_autoreconf -O--buildsystem=pybuild
> > dh_auto_configure -O--buildsystem=pybuild
> > I: pybuild base:217: python3.8 setup.py config
> > running config
> > dh_auto_build -O--buildsystem=pybuild
> > I: pybuild base:217: /usr/bin/python3 setup.py build
> > running build
> > running build_py
> > creating /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/cli.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/mailer.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/__init__.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/storage.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/command.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/worker.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/jobs.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/util.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/config.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/reporters.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/main.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/html2txt.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/handler.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/ical2txt.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/migration.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > copying lib/urlwatch/filters.py ->
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch
> > dh_auto_test -O--buildsystem=pybuild
> > I: pybuild base:217: cd
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build; python3.8 -m nose -v
> test
> > test_filters.test_filters('element_by_tag',) ... ok
> > test_filters.test_filters('element_by_tag_nested',) ... ok
> > test_filters.test_filters('element_by_id',) ... ok
> > test_filters.test_filters('element_by_class',) ... ok
> > test_filters.test_filters('xpath_elements',) ... ok
> > test_filters.test_filters('xpath_text',) ... ok
> > test_filters.test_filters('xpath_exclude',) ... ok
> > test_filters.test_filters('xpath_xml_namespaces',) ... ok
> > test_filters.test_filters('css',) ... ok
> > test_filters.test_filters('css_exclude',) ... ok
> > test_filters.test_filters('css_xml_namespaces',) ... ok
> > test_filters.test_filters('grep',) ... ok
> > test_filters.test_filters('grep_with_comma',) ... ok
> > test_filters.test_filters('json_format',) ... ok
> > test_filters.test_filters('json_format_subfilter',) ... ok
> > test_filters.test_filters('sha1',) ... ok
> > test_filters.test_filters('hexdump',) ... ok
> > test_filters.test_filters('sort',) ... ok
> > test_handler.test_required_classattrs_in_subclasses ... ok
> > test_handler.test_save_load_jobs ... ok
> > test_handler.test_load_config_yaml ... ok
> > test_handler.test_load_urls_txt ... ok
> > test_handler.test_load_urls_yaml ... ok
> > test_handler.test_load_hooks_py ... ok
> > Test that we conform to PEP-8. ... FAIL
> > test_handler.test_run_watcher ... ok
> > test_handler.test_unserialize_shell_job_without_kind ... ok
> > test_handler.test_unserialize_with_unknown_key ... ok
> > test_handler.prepare_retry_test ... ok
> > test_handler.test_number_of_tries_in_cache_is_increased ... ok
> > test_handler.test_report_error_when_out_of_tries ... ok
> > test_handler.test_reset_tries_to_zero_when_successful ... ok
> >
> > ======================================================================
> > FAIL: Test that we conform to PEP-8.
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> > File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in
> runTest
> > self.test(*self.arg)
> > File
> "/<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/test/test_handler.py",
> line 83, in test_pep8_conformance
> > assert result.total_errors == 0, "Found #{0} code style
> errors".format(result.total_errors)
> > AssertionError: Found #3 code style errors
> > -------------------- >> begin captured stdout << ---------------------
> >
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch/reporters.py:140:59:
> E741 ambiguous variable name 'l'
> >
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch/reporters.py:141:59:
> E741 ambiguous variable name 'l'
> >
> /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build/urlwatch/html2txt.py:58:39:
> E741 ambiguous variable name 'l'
> >
> > --------------------- >> end captured stdout << ----------------------
> >
> > ----------------------------------------------------------------------
> > Ran 32 tests in 0.640s
> >
> > FAILED (failures=1)
> > E: pybuild pybuild:352: test: plugin distutils failed with: exit code=1:
> cd /<<PKGBUILDDIR>>/.pybuild/cpython3_3.8_urlwatch/build; python3.8 -m nose
> -v test
> > dh_auto_test: error: pybuild --test --test-nose -i python{version} -p
> 3.8 returned exit code 13
>
> The full build log is available from:
> http://qa-logs.debian.net/2020/06/20/urlwatch_2.18-1_unstable.log
>
> A list of current common problems and possible solutions is available at
> http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!
>
> About the archive rebuild: The rebuild was done on EC2 VM instances from
> Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
> failed build was retried once to eliminate random failures.
>
