Gstreamer packages should be "Suggested" dependencies, not "Recommended".

The issues have been addressed in git master.

https://gitlab.gnome.org/crvi/gnome-activity-journal/-/commits/master

Thanks!

On Mon, 8 Feb 2021 at 01:15, Jonas Smedegaard <d...@jones.dk> wrote:

> Quoting Sudip Mukherjee (2021-02-07 19:41:03)
> > Hi Jonas,
> >
> > On Tue, Feb 02, 2021 at 12:56:52AM +0100, Jonas Smedegaard wrote:
> > > Package: gnome-activity-journal
> > > Version: 1.0.0-1
> > > Severity: important
> > >
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > >
> > > Package is missing dependencies on at least these packages:
> > >
> > > gir1.2-gstreamer-1.0
> > > gir1.2-gnomedesktop-3.0:amd64
> >
> > Thanks for spotting  this.
> > 'gir1.2-gnomedesktop-3.0' is indeed a dependency, but
> 'gir1.2-gstreamer-1.0'
> > is an optional audio preview feature and so I am marking it along with
> > 'gstreamer1.0-gtk3' (which is also an optional video preview feature) as
> > suggested packages. Please let me know if you think this is wrong.
>
> Did you (not only look at code, but) actually test how the application
> behaves when those optional modules are missing?
>
> As I recall, the application failed to run for me when they were
> missing, which indicates that a suggestion is too weak and they should
> at least be recommended. If there is no (exotic) way to make the
> application run without them, they should have a hard dependency.
>
>
>  - Jonas
>
> --
>  * Jonas Smedegaard - idealist & Internet-arkitekt
>  * Tlf.: +45 40843136  Website: http://dr.jones.dk/
>
>  [x] quote me freely  [ ] ask before reusing  [ ] keep private

Reply via email to