Hi!

Guillem Jover wrote:

> The latest version in sid, breaks user code sourcing the git-sh-prompt
> shell library as it moved from /usr/lib/ to /usr/libexec, even though
> I see the comment there says to copy it, but that means no automatic
> upgrades. :/
>
> Could you perhaps add a backwards compatibility symlink for the time
> being? Or when using bash, perhaps even a warning based on the
> “caller” builtin if using the old pathname?

Yeah, I don't advocate copying.  Probably we should patch those
instructions at installation time to recommend sourcing in place
instead.

The git-sh-setup(1) manpage recommends

        . "$(git --exec-path)/git-sh-setup"

but there is no corresponding git-sh-prompt(1) manpage --- yikes.
Ideas:

 a. We could add a NEWS.Debian entry to help people see that the path
    changed and recommend using the $(git --exec-path) based incantation

 b. We could move $(git --exec-path) back to /usr/lib/git-core.  After
    all, while the FHS _allows_ libexec nowadays, it does not require
    it.

 c. As you suggest, we could have a compatibility forwarding script
    that warns to help people update their prompt configuration.

I think I prefer (a) over (c), and that (b) might be best of all.
What do you think?

Thanks,
Jonathan

Reply via email to