On Wednesday, 16 February 2022 00:08:39 CET Cyril Brulebois wrote: > By the way, I still have a branch somewhere with relevant commits for the Pi > 4: > https://salsa.debian.org/debian/raspi-firmware/-/commit/e8b64797f3852e5a133 > d839407e36f6e9c839399 > https://salsa.debian.org/debian/raspi-firmware/-/commit/2db10902f73ca38fff0 > 8b9abb0236ac8e592a2d4 > > and cosmetics: > > https://salsa.debian.org/debian/raspi-firmware/-/commit/0f8b943759ed79eff2c > 8a0e262f92f11c1ac24b2
I wouldn't call that cosmetic and should be squashed into the first commit. Second commit looks good too, but I'd suggest changing the primary commit message. "Add support for Compute Module 4 devices." implies something far greater then adding CM4 to the pi_4_family() function. I have no clue about CM4 and *I* would assume that adding support for that to Bullseye (now) would be out of the question, but you surely know better what is and isn't allowed according to the Release Team ;-) Cheers, Diederik
signature.asc
Description: This is a digitally signed message part.
