Package: telegram-desktop

In raspbian, the update of abseil was delayed compared to Debian due to a build 
failure
that I had to patch[1]. The result of this is that libtgowt was built against 
the old abseil
and this in turn lead to a link failure in telegram-desktop.

I binnmu'd libtgowt in raspbian, and then rescheduled the build of 
telegram-desktop,
this build of telegram-desktop was successful, however it produced a bogus 
built-using
line, which was detected by our infrastructure.

Built-Using: libtgowt (= 0~git20220202.d618d0b+dfsg-2+b1), ms-gsl (= 4.0.0-2), 
range-v3 (= 0.11.0-2), tl-expected (= 1.0.0~dfsg-2)

The problem is that the built-using generation in telegram-desktop correctly 
uses the
source package name, but incorrectly uses the binary package version. This 
doesn't
affect Debian right now because none of the affected packages have been 
binnmu'd in
Debian (and all but one of them are arch all so can't be binnmu'd), but it may 
affect
Debian in the future if libtgowt ever gets binnmu'd.

The fix is trivial, just replacing "Version" with "source:Version" in the 
dpkg-query
call used to generate the Built-Using entries. A debdiff is attatched and I 
would
appreciate it being included in the next upload.

[1] The build failure does not affect any Debian architectures and has been 
reported
upstream at https://github.com/abseil/abseil-cpp/issues/1112
diff -Nru telegram-desktop-3.5.2+ds/debian/changelog 
telegram-desktop-3.5.2+ds/debian/changelog
--- telegram-desktop-3.5.2+ds/debian/changelog  2022-02-10 11:02:02.000000000 
+0000
+++ telegram-desktop-3.5.2+ds/debian/changelog  2022-03-01 23:15:53.000000000 
+0000
@@ -1,3 +1,9 @@
+telegram-desktop (3.5.2+ds-1+rpi1) bookworm-staging; urgency=medium
+
+  * Fix built-using generation to use source version, not binary version.
+
+ -- Peter Michael Green <plugw...@raspbian.org>  Tue, 01 Mar 2022 23:15:53 
+0000
+
 telegram-desktop (3.5.2+ds-1) unstable; urgency=medium
 
   * New upstream release (Closes: #1005255).
diff -Nru telegram-desktop-3.5.2+ds/debian/rules 
telegram-desktop-3.5.2+ds/debian/rules
--- telegram-desktop-3.5.2+ds/debian/rules      2022-01-20 09:33:52.000000000 
+0000
+++ telegram-desktop-3.5.2+ds/debian/rules      2022-03-01 23:15:24.000000000 
+0000
@@ -67,7 +67,7 @@
 
 CPPLIBS_PACKAGES = libexpected-dev libmsgsl-dev librange-v3-dev libtgowt-dev
 EXTRA_SUBSTVARS += \
-       cpplibs:Built-Using=$(shell dpkg-query -Wf 
'$${source:Package}(=$${Version}),' $(CPPLIBS_PACKAGES))
+       cpplibs:Built-Using=$(shell dpkg-query -Wf 
'$${source:Package}(=$${source:Version}),' $(CPPLIBS_PACKAGES))
 
 # Make visible all possible maintainer's flags.
 export DEB_BUILD_MAINT_OPTIONS $(foreach flag,$(DPKG_BUILDFLAGS_LIST),\

Reply via email to