Trent W. Buck wrote:
> I ran into the same bug, except PAGER=cat also fails.
> 
> I also tried fixing ${x-fallback} to the more normal ${x:-fallback}, but it 
> did not help.
> 
> I do not understand why that is happening.
> 
>     root@hera:/gdk-pixbuf# quilt series
>     /usr/share/quilt/scripts/patchfns: line 1128: less: command not found
> 
>     root@hera:/gdk-pixbuf# PAGER=cat quilt series
>     /usr/share/quilt/scripts/patchfns: line 1128: less: command not found

I have some more info.

FAILS:  env         PAGER=cat quilt series
WORKS:  env -u LESS PAGER=cat quilt series


This is actually a separate but related bug in quilt.
If $LESS is set, quilt ignores $PAGER and forces less.
This is wrong.
If quilt wants to override the user's requested $LESS,
it should do so with "export LESS=FRX",
entirely independent of $QUILT_PAGER'.


18:32 <twb> And for comparison, "PAGER=cat git diff" *is* working for git in 
the same environment.
18:32 <twb> I wonder if quilt is getting confused because $HOME doesn't exist?
18:33 <twb> Nope.  But "env -i PAGER=cat quilt series" behaves
18:34 <REDACTED> Bizarre...
18:36 <twb> Get Fucked.
18:36 <twb> env -u LESS fixes it
18:36 <REDACTED> But why?
18:37 <twb> because quilt is broken I guess
18:37 <twb> $LESS should be read by less(1), not by quilt(1)
18:38 <REDACTED> [ -n "$LESS" -a -z "${QUILT_PAGER+x}" ] && QUILT_PAGER="less 
-FRX"
18:38 <REDACTED> Ugh.
18:39 <REDACTED> "env" didn't show anything, because it wasn't exported. We 
should have used "set" instead.

Reply via email to