Hi Matthias, On Tue, 2022-09-13 at 06:12 +0200, matthias.geiger1...@tutanota.de wrote: Hi Mathias,
thanks for reaching out and taking the time for a review. I fixed > all the improvements you mentioned and uploaded the new (old) > version to mentors. That's looking better. However, the Vcs- fields in d/control are still unreachable. When I try to visit "https://salsa.debian.org/werdahias/neo";, I get a not found error. It looks like the correct URL is "https://salsa.debian.org/werdahias/neo-cli";. You should update those two fields so they are correct. After that's fixed, I'd say the package would be in good shape for an upload. There's still some linitian messages that could be addressed, but they aren't highlighting anything too terrible. (You could probably fix them pretty easily and submit a patch/pull request to the upstream developer.) > Regarding cmatrix: neo supports half-japananese characters/unicode, "appearing" text like in The Matrix and 32 bit color support in addition. Thanks for that explanation. That's a good example of additional information you could put in the package's extended description as potential users would find it useful. Also, it's a good idea to always CC the bug address in your replies, especially when they are ITP/RFS bugs. Doing so allows others who might be watching the bug to stay up to date with any work that's being done on it. Mathias
signature.asc
Description: This is a digitally signed message part
