Hi Paul, On 3/12/23 02:44, Paul Eggert wrote: > On 2023-03-11 14:02, Alejandro Colomar wrote: >> we should use "%s" (if we go the way of snprintf(3)). > > Yes, thanks for catching that. However, I came up with a better way that > avoids snprintf (and strlcpy) entirely both here and the other place I > used snprintf. > > Attached is a revised set of patches that addresses the comments you > made and embodies my followups.
I've applied patches 1, 2, 3, and 4 to my repo (I'll take care of them, and forward them to the maintainers). You can rebase to <http://www.alejandro-colomar.es/src/alx/shadow/shadow.git/log/?h=paul> For the rest of the patches, I'll send some comments. Thanks! Alex -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
OpenPGP_signature
Description: OpenPGP digital signature