Package: release.debian.org
Severity: normal
User: release.debian....@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: fwk...@packages.debian.org
Control: affects -1 + src:fwknop

Please unblock package fwknop

[ Reason ]
The AppArmor profile was incorrectly installed in the systemd
system service path:

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034055

[ Impact ]
I'm not sure whether it would cause any actual problems, but it is likely a
policy violation and the bug reporter did file it as an RC bug.

[ Tests ]
I upgraded to the version I uploaded to unstable yesterday and confirmed
that the file is in the new location:

  $ dpkg -L fwknop-apparmor-profile | grep usr.sbin.fwknopd
  /usr/share/apparmor/extra-profiles/usr.sbin.fwknopd

[ Risks ]
Trivial fix. I made it so that the AppArmor profile is not automatically
enabled either to avoid changing (i.e. fixing) the behavior compared to what
it was in -15.

So this should be a no-op in terms of functionality.

[ Checklist ]
  [x] all changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in testing


unblock fwknop/2.6.10-16
diff -Nru fwknop-2.6.10/debian/changelog fwknop-2.6.10/debian/changelog
--- fwknop-2.6.10/debian/changelog	2023-01-10 21:23:46.000000000 -0800
+++ fwknop-2.6.10/debian/changelog	2023-04-10 20:52:01.000000000 -0700
@@ -1,3 +1,12 @@
+fwknop (2.6.10-16) unstable; urgency=high
+
+  * Install apparmor profile in /usr/share/apparmor/extra-profiles/
+    instead of the systemd service directory. Note that the profile
+    will not be used unless manually copied into /etc/apparmor.d/
+    (Closes: #1034055).
+
+ -- Francois Marier <franc...@debian.org>  Mon, 10 Apr 2023 20:52:01 -0700
+
 fwknop (2.6.10-15) unstable; urgency=medium
 
   [ Helmut Grohne ]
diff -Nru fwknop-2.6.10/debian/fwknop-apparmor-profile.install fwknop-2.6.10/debian/fwknop-apparmor-profile.install
--- fwknop-2.6.10/debian/fwknop-apparmor-profile.install	2023-01-10 21:23:46.000000000 -0800
+++ fwknop-2.6.10/debian/fwknop-apparmor-profile.install	2023-04-10 20:52:01.000000000 -0700
@@ -1 +1 @@
-extras/apparmor/usr.sbin.fwknopd	/usr/lib/systemd/system/
+extras/apparmor/usr.sbin.fwknopd	/usr/share/apparmor/extra-profiles/

Reply via email to