On Sun, 30 Apr 2023 20:35:00 +0530 Praveen Arimbrathodiyil
<prav...@onenetbeyond.org> wrote:
> Package: ruby-ruby-parser
> Version: 3.19.2-1
> Severity: important
>
> Gitlab 15.11.0 needs ruby-ruby-parser 3.20 and while trying to update
> it, the build fails with
>
> 13) Failure:
> TestRubyParserV32#test_unless_pre_not__18
> [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:159]:
> failed on input: "unless not b then a end".
> --- expected
> +++ actual
> @@ -1 +1,4 @@
> -s(:if, s(:call, nil, :b), s(:call, nil, :a), nil)
> +s(:if,
> + s(:call, s(:call, nil, :b).line(1), :!).line(1),
> + nil,
> + s(:call, nil, :a).line(1)).line(1)
>
>
> 14) Failure:
> TestRubyParserV32#test_str_question_literal__18
> [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:159]:
> failed on input: "?a".
> --- expected
> +++ actual
> @@ -1 +1 @@
> -s(:lit, 97)
> +s(:str, "a").line(1)
>
>
> 15) Failure:
> TestRubyParserV32#test_while_pre_not__18
> [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:159]:
> failed on input: "while not true do\n (1 + 1)\nend".
> --- expected
> +++ actual
> @@ -1 +1,4 @@
> -s(:until, s(:true), s(:call, s(:lit, 1), :+, s(:lit, 1)), true)
> +s(:while,
> + s(:call, s(:true).line(1), :!).line(1),
> + s(:call, s(:lit, 1).line(2), :+, s(:lit, 1).line(2)).line(2),
> + true).line(1)
>
>
> 16) Failure:
> TestRubyParserV32#test_unless_post_not__18
> [/usr/lib/ruby/vendor_ruby/pt_testcase.rb:159]:
> failed on input: "a unless not b".
> --- expected
> +++ actual
> @@ -1 +1,4 @@
> -s(:if, s(:call, nil, :b), s(:call, nil, :a), nil)
> +s(:if,
> + s(:call, s(:call, nil, :b).line(1), :!).line(1),
> + nil,
> + s(:call, nil, :a).line(1)).line(1)
>
>
Running the tests like upstream would with ruby 3.1 installed via rvm,
the same errors are reproduced.
https://github.com/seattlerb/ruby_parser/issues/337#issuecomment-1535023385
