severity 1041868 important
thanks

Hey pkg-alsa-devel,

Due to my fat-fingering the submit email, the submission of this bug
never hit the ALSA mailing lists. Apologies for the aggressive (in
wallclock time) ping, but I don't think folks here actually saw this. My
control messages came through but not the bug itself.

After sleeping on it I believe this bug is 'important' not 'normal'
because it renders another bit of software unusable (src:direwolf) even
though alsa works fine most of the time, I've adjusted the severity; but
I'm open to having the severity changed.

I'd very much like to land this patch -- it's very short, and attached
to the bug report. The diff is a single char (although single char
changes tend to be the most conceptually hard to reason about), and the
patch was taken from the upstream repo. I'm worried about this bug
propagating out via derivitives, so I'd love to see if we can apply the
patch attached to the bug.

Here's the tl;dr of the patch:

```src/pcm/pcm_hw.c:
-               if (ioctl(hw->fd, SNDRV_PCM_IOCTL_SW_PARAMS, sw_params) < 0) {
+               if (ioctl(hw->fd, SNDRV_PCM_IOCTL_SW_PARAMS, &sw_params) < 0) {
```

I believe this was introduced in alsa-lib 1.2.9, so this is only about a
month old -- and I'd love to stop this from spreading out from sid. It's
already pulled into mantic, and I'm not sure where else.

Thank you for maintaining alsa!
  paultag

-- 
  ⢀⣴⠾⠻⢶⣦⠀               Paul Tagliamonte <paultag>
  ⣾⠁⢠⠒⠀⣿⡁  https://people.debian.org/~paultag | https://pault.ag/
  ⢿⡄⠘⠷⠚⠋        Debian, the universal operating system.
  ⠈⠳⣄⠀⠀  4096R / FEF2 EB20 16E6 A856 B98C  E820 2DCD 6B5D E858 ADF3

Attachment: signature.asc
Description: PGP signature

Reply via email to