On August 14, 2023 12:28:30 PM UTC, Andreas Tille <andr...@an3as.eu> wrote:
>Control: tags -1 pending
>
>Hi,
>
>I've fixed the issue reported in this bug[1].
>
>In addition I've took the chance to upload pdm to its latest upstream
>version. When doing so I realised that build time tests are basically
>ignored. This was mainly due to the removal of artefacts that are used
>for testing. I admit I do not see any reason to remove those data
>files - in Debian R team this kind of data files which is just used for
>testing is accepted. Thus I took the freedom to re-introduce these
>files and was running the tests in d/rules. Unfortunately there is
>quite a number of tests failing
>
> ======== 54 failed, 620 passed, 1 xfailed, 3 rerun in 228.94s (0:03:48)
> ========
>
>(see Salsa CI[2])
>
>I'd like to stress that to run those tests at all I needed a patch[3]
>since BaseProvider can't be simply imported from findpython.
>
>Before I upload I'd like to ask for reviewing this patch and opinions
>about the test suite errors. While these possibly occure in previous
>versions (which I did not tested) we might consider ignoring just the
>failing tests. I need to admit that I did not went through the list of
>single failures - may be there is a chance of easy fixes for some of
>them. I simply wanted to discuss the reintroduction of the artifacts
>and my patch first.
>
With the exception of future_fstrings those are all binary without source.
That's a problem. It's probably okay if you add the corresponding source
somewhere in the package.
I do think it's odd that pdm would need poetry-core in its test suit.
Scott K
