Package: munin-node
Version: 2.0.73-2
Severity: normal
Tags: patch

The recent upgrade to 2.0.73-2 from 2.0.73-1 introduced the following changes.

--- a/logrotate.d/munin-node
+++ b/logrotate.d/munin-node
@@ -3,7 +3,11 @@
        missingok
        rotate 7
        compress
-       copytruncate
+       nocopytruncate
+       delaycompress
        notifempty
        create 640 root root
+       postrotate
+               systemctl restart munin-node
+       endscript
 }

The introduction of systemctl is problematic especially when used in
chroots.  It avoids the policy-rc.d layer.  Please see this reference
for details.

    
https://www.debian.org/doc/debian-policy/ch-opersys.html#running-init-scripts

Please use invoke-rc.d like other logrotate.d files do.  Here is a
patch.  I note that TABs were used and that those will probably not be
preserved and will need to be manually handled as desired.

--- a/logrotate.d/munin-node
+++ b/logrotate.d/munin-node
@@ -8,6 +8,6 @@
        notifempty
        create 640 root root
        postrotate
-               systemctl restart munin-node
+               invoke-rc.d munin-node restart > /dev/null
        endscript
 }

Thank you for maintaining munin-node in Debian.

Bob


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)

Reply via email to