On Tue, Nov 14, 2023 at 07:45:36AM +0000, Krämer, Jan wrote: > Hi Tobias, > > I still have some questions: > > - Is it permitted to update the libsilkit version (to 4.0.39) within the > review process? Yes, you can update to a later version.
(if you do so, just upload it to mentors.d.n and then retitle this RFS bug to reflect the new version.) > - The only remaining vendoring is GoogleTest, which is only used for > the unit/integration tests which are not shipped by the package. Is > this allowed or should we use the systems libraries here as well? It's packaged, so the packaged version should be used. > - Related, if this is allowed, do we need to include the License > information, since we do not ship source files nor object files > compiled with these source files in the binary package? My understanding is that your d/copyright needs to reflect *everything* you ship in your orig.tar. > Cheers and thanks again for the review, > Jan Cheers, -- tobi
