Hi On 03-01-2024 12:44, Colin Watson wrote:
While at some point you might want to do a bit more abstraction to
reduce code duplication, I think the simplest approach would be to copy
autopkgtest-{build,virt}-lxd to autopkgtest-{build,virt}-incus and do a
little bit of search-and-replace. I've filed
https://salsa.debian.org/ci-team/autopkgtest/-/merge_requests/272 for
this. To help with review, here's the diff against the LXD versions.
Yes, please let's not do this. src:autopkgtest already has a huge technical dept, I don't want to add such a copy/paste thing to it. I suggest you declare a variable at the start and use that everywhere where you now have a diff. And suggest a way how that script can take the option (e.g. make the current script a wrapper to a new cloned script with the behavior it gets lxd, while the new script requires you to define it, or something).
Paul
OpenPGP_signature.asc
Description: OpenPGP digital signature
