Source: rtpengine
Version: 11.5.1.14-1
Severity: normal
Tags: patch
User: helm...@debian.org
Usertags: dep17m2
Your package currently hard-codes the install path for two systemd
unit symlinks. Attached is a patch to have this based on systemd.pc.
The motivation for this is the currently ongoing UsrMerge effort
[1], and I figured you likely want the same source package to work
on earlier releases.
The patch has been build-tested and checked by dumat, piuparts and
autopkgtest.
If you don't need to support earlier releases, you can just
hard-code the path in /usr/lib.
Please consider uploading this sooner than later, but in any case it
should go in for trixie.
Chris
[1] https://wiki.debian.org/UsrMerge
diff -Nru rtpengine-11.5.1.14/debian/changelog rtpengine-11.5.1.14/debian/changelog
--- rtpengine-11.5.1.14/debian/changelog 2023-11-17 13:29:29.000000000 +0100
+++ rtpengine-11.5.1.14/debian/changelog 2024-01-08 14:11:28.000000000 +0100
@@ -1,3 +1,10 @@
+rtpengine (11.5.1.14-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Honor systemdsystemunitdir from systemd.pc (DEP17 M2) (Closes: #-1)
+
+ -- Chris Hofstaedtler <z...@debian.org> Mon, 08 Jan 2024 14:11:28 +0100
+
rtpengine (11.5.1.14-1) unstable; urgency=medium
* New upstream version 11.5.1.14
diff -Nru rtpengine-11.5.1.14/debian/control rtpengine-11.5.1.14/debian/control
--- rtpengine-11.5.1.14/debian/control 2023-11-17 13:29:29.000000000 +0100
+++ rtpengine-11.5.1.14/debian/control 2024-01-08 14:09:18.000000000 +0100
@@ -52,8 +52,10 @@
libxtables-dev (>= 1.4) | iptables-dev (>= 1.4),
markdown,
pandoc,
+ pkgconf,
python3,
python3-websockets,
+ systemd-dev | systemd,
zlib1g-dev,
Testsuite: autopkgtest-pkg-dkms
diff -Nru rtpengine-11.5.1.14/debian/rtpengine-daemon.links rtpengine-11.5.1.14/debian/rtpengine-daemon.links
--- rtpengine-11.5.1.14/debian/rtpengine-daemon.links 2023-11-17 13:29:29.000000000 +0100
+++ rtpengine-11.5.1.14/debian/rtpengine-daemon.links 2024-01-08 14:10:41.000000000 +0100
@@ -1 +1 @@
-/lib/systemd/system/rtpengine-daemon.service /lib/systemd/system/rtpengine.service
+${env:deb_systemdsystemunitdir}/rtpengine-daemon.service ${env:deb_systemdsystemunitdir}/rtpengine.service
diff -Nru rtpengine-11.5.1.14/debian/rtpengine-recording-daemon.links rtpengine-11.5.1.14/debian/rtpengine-recording-daemon.links
--- rtpengine-11.5.1.14/debian/rtpengine-recording-daemon.links 2023-11-17 13:29:29.000000000 +0100
+++ rtpengine-11.5.1.14/debian/rtpengine-recording-daemon.links 2024-01-08 14:11:07.000000000 +0100
@@ -1 +1 @@
-/lib/systemd/system/rtpengine-recording-daemon.service /lib/systemd/system/rtpengine-recording.service
+${env:deb_systemdsystemunitdir}/rtpengine-recording-daemon.service ${env:deb_systemdsystemunitdir}/rtpengine-recording.service
diff -Nru rtpengine-11.5.1.14/debian/rules rtpengine-11.5.1.14/debian/rules
--- rtpengine-11.5.1.14/debian/rules 2023-11-17 13:29:29.000000000 +0100
+++ rtpengine-11.5.1.14/debian/rules 2024-01-08 14:10:17.000000000 +0100
@@ -19,6 +19,8 @@
export DEB_LDFLAGS_MAINT_SET =
endif
+export deb_systemdsystemunitdir = $(shell pkg-config --variable=systemdsystemunitdir systemd)
+
%:
dh $@
