El 23/01/24 a las 10:34, Helmut Grohne escribió:
> On Tue, Jan 23, 2024 at 01:29:51AM +0100, Chris Hofstaedtler wrote:
> > Attached is an improved patch, that avoids the temporary file loss
> > that could occur in the old version. This is mostly based on work by
> > Helmut Grohne.
> 
> Thank you.
> 
> Reviewed-by: Helmut Grohne <hel...@subdivi.de>
> 
> I could not identify issues. The begin-remove-after markup feels
> slightly inconsistent as it partially cleans up the mitigation, but
> cleaning up the part in -ddns using this simple markup is non-trivial
> and keeping those snippets a little longer shall not cause breakage, so
> while this isn't perfect, I think it's good to go as is.
> 
> I also locally built this change and performed bootstrap testing with
> debootstrap, cdebootstrap and mmebstrap (which include isc-dhcp-client
> in the larger variants).
> 
> > Please consider this version of the patch.
> 
> I second this request. I appreciate to have this resolved by the end of
> February. Preferrably, we have this change in experimental for a few
> days before transitioning to unstable to allow for more QA.
> 
> Helmut

Done. Thanks a lot to both of your for your work.

Attachment: signature.asc
Description: PGP signature

Reply via email to