On Thu, Feb 01, 2024 at 02:35:54PM +0100, Andre Noll wrote: > On Thu, Feb 01, 09:42, Steve Langasek wrote:
> Thanks for the patch. I've applied it to a temporary git branch for > now, see below. Since the previous upload (1.0.4-1 in 2023-06) two > unrelated bugs have been found and fixed, so it would be good to get > these in as well. Do you want me to adjust the debian/changelog to > mention these fixes before merging the temporary branch? > > If you have any concerns about this patch, please reach out ASAP. > No concerns but some questions: > * The tfortune package depends on liblopsub and currently has > Depends: ${shlibs:Depends}, liblopsub1, ${misc:Depends} > in its own debian/control file. When would be the best time to replace > liblopsub1 by liblopsub1t64? You should just drop this hard-coded dependency on liblopsub1. This is what shlibs are for. > * Why did you call the new version 1.0.4-1.1? Why not 1.0.5-1 instead? This is a very basic question about package versioning which is answered in Debian Policy. > * Do I need to do anything else to get this going besides merging > the branch and pushing it to the public repo? No. Please do not upload this change to unstable; these changes will be batch-uploaded to unstable at the appropriate time, *after* dpkg has been uploaded to unstable changing the default build flags. Once the NMU has been uploaded to unstable, you are free to make further uploads to unstable incorporating this change. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature