Package: u-boot-tools
Version: 2024.01+dfsg-1
Severity: normal
File: /usr/bin/mkimage

Dear Maintainer,

From a strace:
  1390  openat(AT_FDCWD, "/tmp/tmp.j2DX6x1MgV/Image-6.6.11.lz4", O_RDONLY) = 3
  1390  newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=12611929, ...}, 
AT_EMPTY_PATH) = 0
  1390  close(3)                          = 0
  1390  openat(AT_FDCWD, "mt8173-elm-hana-6.6.11.dtb", O_RDONLY) = 3
  1390  newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=43853, ...}, 
AT_EMPTY_PATH) = 0
  1390  close(3)                          = 0
  1390  mmap(NULL, 12660736, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, 
-1, 0) = 0xffffafecd000
  1390  openat(AT_FDCWD, "/tmp/tmp.j2DX6x1MgV/Image-6.6.11.lz4", O_RDWR) = 3
  1390  newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=12611929, ...}, 
AT_EMPTY_PATH) = 0
  1390  read(3, "\4\"M\30dp\271\361K!\0\225\37 \3\325'\360X\24\0\1\0 
\243\1\6\0/\n\0\1"..., 12611929) = 12611929
  1390  close(3)                          = 0
  1390  openat(AT_FDCWD, "mt8173-elm-hana-6.6.11.dtb", O_RDWR) = -1 EACCES 
(Permission denied)
  1390  write(2, "mkimage: Can't open mt8173-elm-h"..., 66) = 66
  1390  write(2, "mkimage: Failed to build FIT ima"..., 35) = 35
  1390  munmap(0xffffafecd000, 12660736)  = 0
here, the dtb is unwritable.

An analogous error happens if the Image is unwritable,
but as we can see here, it doesn't write to it anyway.
(Nor should it, given this is an input file.)

Please turn this into an O_RDONLY.

Best,
наб

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: arm64 (aarch64)

Kernel: Linux 6.6.11 (SMP w/4 CPU threads)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages u-boot-tools depends on:
ii  libc6        2.37-15
ii  libgnutls30  3.8.3-1
ii  libssl3      3.1.4-2
ii  libtinfo6    6.4+20240113-1
ii  libuuid1     2.39.3-6

Versions of packages u-boot-tools recommends:
pn  device-tree-compiler  <none>
pn  libubootenv-tool      <none>

u-boot-tools suggests no packages.

-- no debconf information

Attachment: signature.asc
Description: PGP signature

Reply via email to