Package: vokoscreen-ng
Version: 3.7.0-1
Severity: normal
Tags: patch
X-Debbugs-Cc: wes...@schwengle.net

Dear Maintainer,

I started up vokoscreen and saw there was an update available for vokoscreen.
When running this app from source that might be great information, but from a
Debian point of view this is unwanted.

I patched vokoscreen-ng with 3 patches, for version 3.5.0 (stable),
v3.7.0 (unstable/testing) and v3.8.0, which would be nice to have in Debian
unstable perhaps?

Patches are attached.

-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (500, 'experimental'), (500, 'testing'), (10, 
'stable-updates'), (10, 'stable-security'), (10, 'oldstable-security'), (10, 
'oldoldstable'), (10, 'stable'), (10, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.6.15-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE=en_US:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages vokoscreen-ng depends on:
ii  gstreamer1.0-plugins-good  1.22.10-1
ii  libc6                      2.37-15
ii  libgcc-s1                  14-20240201-3
ii  libglib2.0-0               2.78.4-1
ii  libgstreamer1.0-0          1.22.10-1
ii  libpulse0                  16.1+dfsg1-3
ii  libqt5core5a               5.15.10+dfsg-7
ii  libqt5dbus5                5.15.10+dfsg-7
ii  libqt5gui5                 5.15.10+dfsg-7
ii  libqt5multimedia5          5.15.10-2+b1
ii  libqt5network5             5.15.10+dfsg-7
ii  libqt5widgets5             5.15.10+dfsg-7
ii  libqt5x11extras5           5.15.10-2+b1
ii  libstdc++6                 14-20240201-3
ii  libwayland-client0         1.22.0-2.1+b1
ii  libx11-6                   2:1.8.7-1

Versions of packages vokoscreen-ng recommends:
ii  gstreamer1.0-libav         1.22.10-1
ii  gstreamer1.0-pulseaudio    1.22.10-1
ii  libqt5multimedia5-plugins  5.15.10-2+b1
pn  pulseaudio                 <none>

Versions of packages vokoscreen-ng suggests:
ii  gstreamer1.0-plugins-bad   1.22.10-1
ii  gstreamer1.0-plugins-ugly  1.22.10-1
ii  gstreamer1.0-vaapi         1.22.10-1
ii  intel-media-va-driver      24.1.0+dfsg1-1

-- debconf-show failed
>From eac5373d61b1984b1da8b5a1f019631ff46b4dd2 Mon Sep 17 00:00:00 2001
From: Wesley Schwengle <wesl...@opperschaap.net>
Date: Tue, 27 Feb 2024 14:01:25 -0400
Subject: [PATCH] Don't show update information

The application tells a user that an update is available. This is the
opposite of what we want in Debian. We want users to only update when
Debian ships a new .deb. Remove the bits from source.

Signed-off-by: Wesley Schwengle <wesl...@opperschaap.net>
---
 src/formMainWindow.ui              | 34 ------------------------------
 src/information/QvkInformation.cpp | 29 +------------------------
 src/information/QvkInformation.h   |  2 --
 3 files changed, 1 insertion(+), 64 deletions(-)

diff --git a/src/formMainWindow.ui b/src/formMainWindow.ui
index 7e17f8cb..e59a4dc3 100644
--- a/src/formMainWindow.ui
+++ b/src/formMainWindow.ui
@@ -2042,40 +2042,6 @@
                 </item>
                </layout>
               </item>
-              <item row="7" column="0">
-               <layout class="QHBoxLayout" name="horizontalLayout_17">
-                <item>
-                 <widget class="QCheckBox" name="checkBoxLookForUpdates">
-                  <property name="text">
-                   <string>Look for updates</string>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <widget class="QLabel" name="label_Upate_tab_4">
-                  <property name="text">
-                   <string notr="true">TextLabel</string>
-                  </property>
-                  <property name="openExternalLinks">
-                   <bool>true</bool>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <spacer name="horizontalSpacer_3">
-                  <property name="orientation">
-                   <enum>Qt::Horizontal</enum>
-                  </property>
-                  <property name="sizeHint" stdset="0">
-                   <size>
-                    <width>40</width>
-                    <height>20</height>
-                   </size>
-                  </property>
-                 </spacer>
-                </item>
-               </layout>
-              </item>
               <item row="4" column="0">
                <layout class="QHBoxLayout" name="horizontalLayout_31">
                 <item>
diff --git a/src/information/QvkInformation.cpp 
b/src/information/QvkInformation.cpp
index 282a587d..82de9555 100644
--- a/src/information/QvkInformation.cpp
+++ b/src/information/QvkInformation.cpp
@@ -66,11 +66,8 @@ QvkInformation::QvkInformation( QvkMainWindow *vkMainWindow,
     connect( ui->pushButtonPause,    SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( stop() ) );
     connect( ui->pushButtonContinue, SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( start() ) );
 
-    // Update
+    // Debian doesn't need the updates because of the release model
     ui->label_Upate_tab_1->clear();
-    ui->label_Upate_tab_4->clear();
-    connect( &version, SIGNAL( signal_newVersionAvailable( QString ) ), this, 
SLOT( slot_newVersionAvailable( QString ) ) );
-    connect( ui->checkBoxLookForUpdates, SIGNAL( toggled( bool ) ), &version, 
SLOT( slot_doDownload( bool ) ) );
 
     // Frames, Format, Codecs
     connect( ui->comboBoxFormat,       SIGNAL( currentTextChanged( QString ) 
), this, SLOT( slot_Format( QString ) ) );
@@ -125,30 +122,6 @@ void QvkInformation::slot_Frames( int value )
     ui->labelInfoFrames->setText( QString::number( value ) );
 }
 
-
-void QvkInformation::slot_newVersionAvailable( QString update )
-{
-    if ( ui->checkBoxLookForUpdates->isChecked() == true )
-    {
-        if ( global::version < update )
-        {
-            QString string = "New Version available: " + update;
-            ui->label_Upate_tab_1->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-        }
-        else
-        {
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>No 
update available</a>" );
-        }
-    }
-    else
-    {
-        ui->label_Upate_tab_1->clear();
-        ui->label_Upate_tab_4->clear();
-    }
-}
-
-
 void QvkInformation::slot_cleanup()
 {
     timerStorageInfo->stop();
diff --git a/src/information/QvkInformation.h b/src/information/QvkInformation.h
index 41ae268a..4e9875d3 100644
--- a/src/information/QvkInformation.h
+++ b/src/information/QvkInformation.h
@@ -54,8 +54,6 @@ private slots:
 
   void slot_summedTimeAfterPause();
 
-  void slot_newVersionAvailable( QString update );
-
   void slot_Format( QString value );
   void slot_Videocodec( QString value );
   void slot_Audiocodec( QString value );
-- 
2.44.0.297.g8ee07f1da4

>From 1499f77b3b005cf6042528b753a795d31cefc504 Mon Sep 17 00:00:00 2001
From: Wesley Schwengle <wesl...@opperschaap.net>
Date: Tue, 27 Feb 2024 13:42:50 -0400
Subject: [PATCH] Don't show update information

The application tells a user that an update is available. This is the
opposite of what we want in Debian. We want users to only update when
Debian ships a new .deb. Remove the bits from source, tested against
3.7.0 (current stable version).

Signed-off-by: Wesley Schwengle <wesl...@opperschaap.net>
---
 src/formMainWindow.ui              | 34 ----------------------------
 src/information/QvkInformation.cpp | 36 +-----------------------------
 src/information/QvkInformation.h   |  2 --
 3 files changed, 1 insertion(+), 71 deletions(-)

diff --git a/src/formMainWindow.ui b/src/formMainWindow.ui
index c19e243b..b6070646 100644
--- a/src/formMainWindow.ui
+++ b/src/formMainWindow.ui
@@ -1968,40 +1968,6 @@
                 </item>
                </layout>
               </item>
-              <item row="7" column="0">
-               <layout class="QHBoxLayout" name="horizontalLayout_17">
-                <item>
-                 <widget class="QCheckBox" name="checkBoxLookForUpdates">
-                  <property name="text">
-                   <string>Look for updates</string>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <widget class="QLabel" name="label_Upate_tab_4">
-                  <property name="text">
-                   <string notr="true">TextLabel</string>
-                  </property>
-                  <property name="openExternalLinks">
-                   <bool>true</bool>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <spacer name="horizontalSpacer_3">
-                  <property name="orientation">
-                   <enum>Qt::Horizontal</enum>
-                  </property>
-                  <property name="sizeHint" stdset="0">
-                   <size>
-                    <width>40</width>
-                    <height>20</height>
-                   </size>
-                  </property>
-                 </spacer>
-                </item>
-               </layout>
-              </item>
               <item row="4" column="0">
                <layout class="QHBoxLayout" name="horizontalLayout_31">
                 <item>
diff --git a/src/information/QvkInformation.cpp 
b/src/information/QvkInformation.cpp
index f24b85f6..9e7bf813 100644
--- a/src/information/QvkInformation.cpp
+++ b/src/information/QvkInformation.cpp
@@ -67,11 +67,8 @@ QvkInformation::QvkInformation( QvkMainWindow *vkMainWindow,
     connect( ui->pushButtonPause,    SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( stop() ) );
     connect( ui->pushButtonContinue, SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( start() ) );
 
-    // Update
+    // Debian doesn't need the updates because of the release model
     ui->label_Upate_tab_1->clear();
-    ui->label_Upate_tab_4->clear();
-    connect( &version, SIGNAL( signal_newVersionAvailable( QString ) ), this, 
SLOT( slot_newVersionAvailable( QString ) ) );
-    connect( ui->checkBoxLookForUpdates, SIGNAL( toggled( bool ) ), &version, 
SLOT( slot_doDownload( bool ) ) );
 
     // Frames, Format, Codecs
     connect( ui->comboBoxFormat,       SIGNAL( currentTextChanged( QString ) 
), this, SLOT( slot_Format( QString ) ) );
@@ -126,37 +123,6 @@ void QvkInformation::slot_Frames( int value )
     ui->labelInfoFrames->setText( QString::number( value ) );
 }
 
-
-void QvkInformation::slot_newVersionAvailable( QString update )
-{
-    if ( ui->checkBoxLookForUpdates->isChecked() == true )
-    {
-        if ( global::version < update )
-        {
-            QString string = "New Version available: " + update;
-            ui->label_Upate_tab_1->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-
-            QvkShowMessage *vkShowMessage = new QvkShowMessage;
-            vkShowMessage->set_WindowIcon( QIcon( ":/pictures/logo/logo.png" ) 
);
-            vkShowMessage->set_WindowTitle( global::name + " " + 
global::version );
-            vkShowMessage->set_URL( 
"https://linuxecke.volkoh.de/vokoscreen/vokoscreen.html"; );
-            vkShowMessage->set_StatusIcon( ":/pictures/status/information.png" 
);
-            vkShowMessage->showMessage( "New Version available: " + update );
-        }
-        else
-        {
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>No 
update available</a>" );
-        }
-    }
-    else
-    {
-        ui->label_Upate_tab_1->clear();
-        ui->label_Upate_tab_4->clear();
-    }
-}
-
-
 void QvkInformation::slot_cleanup()
 {
     timerStorageInfo->stop();
diff --git a/src/information/QvkInformation.h b/src/information/QvkInformation.h
index 41ae268a..4e9875d3 100644
--- a/src/information/QvkInformation.h
+++ b/src/information/QvkInformation.h
@@ -54,8 +54,6 @@ private slots:
 
   void slot_summedTimeAfterPause();
 
-  void slot_newVersionAvailable( QString update );
-
   void slot_Format( QString value );
   void slot_Videocodec( QString value );
   void slot_Audiocodec( QString value );
-- 
2.44.0.297.g8ee07f1da4

>From d51c3ffbda638983e0b44e4ec0bf9df2fd8ea7c5 Mon Sep 17 00:00:00 2001
From: Wesley Schwengle <wesl...@opperschaap.net>
Date: Tue, 27 Feb 2024 13:48:51 -0400
Subject: [PATCH] Don't show update information

The application tells a user that an update is available. This is the
opposite of what we want in Debian. We want users to only update when
Debian ships a new .deb. Remove the bits from source, tested against
3.7.0 (current stable version).

Signed-off-by: Wesley Schwengle <wesl...@opperschaap.net>
---
 src/formMainWindow.ui              | 44 ------------------------------
 src/information/QvkInformation.cpp | 30 +-------------------
 src/information/QvkInformation.h   |  2 --
 3 files changed, 1 insertion(+), 75 deletions(-)

diff --git a/src/formMainWindow.ui b/src/formMainWindow.ui
index cf94d7e4..cd8d5a2e 100644
--- a/src/formMainWindow.ui
+++ b/src/formMainWindow.ui
@@ -2145,40 +2145,6 @@
                 </property>
                </widget>
               </item>
-              <item row="12" column="0">
-               <layout class="QHBoxLayout" name="horizontalLayout_17">
-                <item>
-                 <widget class="QCheckBox" name="checkBoxLookForUpdates">
-                  <property name="text">
-                   <string>Look for updates</string>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <widget class="QLabel" name="label_Upate_tab_4">
-                  <property name="text">
-                   <string notr="true">TextLabel</string>
-                  </property>
-                  <property name="openExternalLinks">
-                   <bool>true</bool>
-                  </property>
-                 </widget>
-                </item>
-                <item>
-                 <spacer name="horizontalSpacer_3">
-                  <property name="orientation">
-                   <enum>Qt::Horizontal</enum>
-                  </property>
-                  <property name="sizeHint" stdset="0">
-                   <size>
-                    <width>40</width>
-                    <height>20</height>
-                   </size>
-                  </property>
-                 </spacer>
-                </item>
-               </layout>
-              </item>
               <item row="13" column="0">
                <layout class="QHBoxLayout" name="horizontalLayout_36">
                 <item>
@@ -2213,16 +2179,6 @@
                 </item>
                </layout>
               </item>
-              <item row="12" column="2">
-               <widget class="QToolButton" 
name="help_screencast_lookforupdates">
-                <property name="toolTip">
-                 <string>Help</string>
-                </property>
-                <property name="text">
-                 <string>Help</string>
-                </property>
-               </widget>
-              </item>
               <item row="4" column="0">
                <layout class="QHBoxLayout" name="horizontalLayout_31">
                 <item>
diff --git a/src/information/QvkInformation.cpp 
b/src/information/QvkInformation.cpp
index 9a3b5634..b837392e 100644
--- a/src/information/QvkInformation.cpp
+++ b/src/information/QvkInformation.cpp
@@ -67,11 +67,8 @@ QvkInformation::QvkInformation( QvkMainWindow *vkMainWindow,
     connect( ui->pushButtonPause,    SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( stop() ) );
     connect( ui->pushButtonContinue, SIGNAL( clicked( bool ) ), timerRecord, 
SLOT( start() ) );
 
-    // Update
+    // Debian doesn't need the updates because of the release model
     ui->label_Upate_tab_1->clear();
-    ui->label_Upate_tab_4->clear();
-    connect( &version, SIGNAL( signal_newVersionAvailable( QString ) ), this, 
SLOT( slot_newVersionAvailable( QString ) ) );
-    connect( ui->checkBoxLookForUpdates, SIGNAL( toggled( bool ) ), &version, 
SLOT( slot_doDownload( bool ) ) );
 
     // Frames, Format, Codecs
     connect( ui->comboBoxFormat,       SIGNAL( currentTextChanged( QString ) 
), this, SLOT( slot_Format( QString ) ) );
@@ -124,31 +121,6 @@ void QvkInformation::slot_Frames( int value )
     ui->labelInfoFrames->setText( QString::number( value ) );
 }
 
-
-void QvkInformation::slot_newVersionAvailable( QString update )
-{
-    if ( ui->checkBoxLookForUpdates->isChecked() == true ) {
-        if ( global::version < update ) {
-            QString string = "New Version available: " + update;
-            ui->label_Upate_tab_1->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>" + 
string + "</a>" );
-
-            QvkShowMessage *vkShowMessage = new QvkShowMessage;
-            vkShowMessage->set_WindowIcon( QIcon( ":/pictures/logo/logo.png" ) 
);
-            vkShowMessage->set_WindowTitle( global::name + " " + 
global::version );
-            vkShowMessage->set_URL( 
"https://linuxecke.volkoh.de/vokoscreen/vokoscreen.html"; );
-            vkShowMessage->set_StatusIcon( ":/pictures/status/information.png" 
);
-            vkShowMessage->showMessage( "New Version available: " + update );
-        } else {
-            ui->label_Upate_tab_4->setText( "<a 
href='https://linuxecke.volkoh.de/vokoscreen/vokoscreen-download.html'>No 
update available</a>" );
-        }
-    } else {
-        ui->label_Upate_tab_1->clear();
-        ui->label_Upate_tab_4->clear();
-    }
-}
-
-
 void QvkInformation::slot_cleanup()
 {
     timerStorageInfo->stop();
diff --git a/src/information/QvkInformation.h b/src/information/QvkInformation.h
index 41ae268a..4e9875d3 100644
--- a/src/information/QvkInformation.h
+++ b/src/information/QvkInformation.h
@@ -54,8 +54,6 @@ private slots:
 
   void slot_summedTimeAfterPause();
 
-  void slot_newVersionAvailable( QString update );
-
   void slot_Format( QString value );
   void slot_Videocodec( QString value );
   void slot_Audiocodec( QString value );
-- 
2.44.0.297.g8ee07f1da4

Reply via email to