Hi Josua,

On Tuesday, 12 March 2024 16:28:06 CET Josua Mayer wrote:
> I believe I found the answer:
> EDAC_MPC85XX is for power-pc only,
> EDAC_LAYERSCAPE is for arm (see drivers/edac/layerscape_edac.c).

You're right. In the commit I referenced earlier (ea2eb9a8b6207ee4),
I misinterpreted the commit message.
That commit also created ``drivers/edac/fsl_ddr_edac.c`` which got the arch 
independent (or at least dual arch) parts. Its header has this:
```
 * Support Power-based SoCs including MPC85xx, MPC86xx, MPC83xx and
 * ARM-based Layerscape SoCs including LS2xxx. Originally split
 * out from mpc85xx_edac EDAC driver.
```

> Am 12.03.24 um 16:13 schrieb Josua Mayer:
> >
> > Thank you for taking care of this!
> > First the additional changes you found seem reasonable.

Excellent, then I'll make a MR for them (except EDAC_MPC85XX):
- drivers/hwmon/pmbus: Enable PMBUS, SENSORS_PMBUS and
   SENSORS_LTC2978 as modules
- drivers/nvmem: Enable NVMEM_LAYERSCAPE_SFP as module
- drivers/rtc: Enable RTC_DRV_FSL_FTM_ALARM as module
- drivers/soc/fsl: Enable FSL_RCPM

> > Regarding edac - I checked NXPs reference BSP for LX2160,
> > and their linux fork has the same status, driver can not be enabled on
> > arm64.
> > However I also agree it should be enabled if it were possible.
> > The driver appears to setup ecc bit error interrupts so that hey can be
> > reported by Linux.
> > ...
> > I may have access to an lx2160a system with ecc memory within the coming
> > week, so I could test (on vendor kernel based on 5.10 only) whether any
> > problems show up. If not, perhaps a patch to the kernel is advisable.

As EDAC_LAYERSCAPE got enabled in 5.5.17-1 via bug 948576 (with a patch from 
you), ECC support should already work with the Stable 6.1 kernel (or newer).

> > Am 07.03.24 um 13:34 schrieb Diederik de Haas:
> >> On Thursday, 18 January 2024 17:40:38 CET Josua Mayer wrote:
> >> 
> >>> LX2160 SoC early silicon revisions have a pci-e generation 4
> >>> controller.
> >>> It requires a different driver from newer gen-3 silicon.
> >>>
> >>> This affects the SolidRun Honeycomb Workstation which
> >>> is otherwise fully supported in Debian.
> >> 
> >> I cloned bug report #1061116 into #1065611 to discuss some additional
> >> support for the SolidRun HoneyComb.
> >>
> >> I analyzed the HoneyComb dts file and the following included .dtsi
> >> files:
> >> - arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> >> - arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> >> - arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi

If my MR gets merged, then there's truly full support in Debian :)

Cheers,
  Diederik

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to