On 2024-03-13 18:07 +0100, Sven Joachim wrote: > Control: forwarded -1 > https://gitlab.freedesktop.org/xorg/driver/xf86-video-nouveau/-/issues/569 > > On 2024-03-13 12:47 +0100, Lucas Nussbaum wrote: > >> Source: xserver-xorg-video-nouveau >> Version: 1:1.0.17-2 >> Severity: serious >> Justification: FTBFS >> Tags: trixie sid ftbfs >> User: lu...@debian.org >> Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef >> >> Hi, >> >> During a rebuild of all packages in sid, your package failed to build >> on amd64. >> >> This is most likely caused by a change in dpkg 1.22.6, that enabled >> -Werror=implicit-function-declaration. For more information, see >> https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration >> >> Relevant part (hopefully): >>> /bin/bash ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H >>> -I. -I../../src -I.. -Wdate-time -D_FORTIFY_SOURCE=2 >>> -I/usr/include/xorg -fvisibility=hidden -I/usr/include/pixman-1 >>> -I/usr/include/X11/dri -I/usr/include/libdrm -I/usr/include/libdrm >>> -I/usr/include/libdrm/nouveau -I/usr/include/libdrm -g -O2 >>> -Werror=implicit-function-declaration >>> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong >>> -fstack-clash-protection -Wformat -Werror=format-security >>> -fcf-protection -Wall -minline-all-stringops -I/usr/include/xorg >>> -fvisibility=hidden -I/usr/include/pixman-1 -I/usr/include/X11/dri >>> -I/usr/include/libdrm -c -o nv04_xv_ovl.lo ../../src/nv04_xv_ovl.c >>> ../../src/nv_driver.c: In function ‘NVScreenInit’: >>> ../../src/nv_driver.c:1451:23: error: implicit declaration of >>> function ‘wfbScreenInit’; did you mean ‘fbScreenInit’? >>> [-Werror=implicit-function-declaration] >>> 1451 | ret = wfbScreenInit(pScreen, FBStart, >>> pScrn->virtualX, >>> | ^~~~~~~~~~~~~ >>> | fbScreenInit > > This has already been reported upstream, unfortunately without a > followup so far.
Got a reply from Alan Coppersmith, and he mentioned a fix to xorg's fb.h header file which is in the Xserver master branch, but has not yet been applied to the server-21.1-branch. > Adding -DFB_ACCESS_WRAPPER to CPPFLAGS lets the build > succeed, but I have not tested the resulting binary package yet. Tested it now, and it does not work at all, xinit fails to start: ,---- | /usr/lib/xorg/Xorg: symbol lookup error: /usr/lib/xorg/modules/drivers/nouveau_drv.so: undefined symbol: wfbPictureInit `---- > See commit d7ba24fb6e4f ("wfb: Fix missing init function decls behind > FB_ACCESS_WRAPPER") which noticed and fixed the missing function > declaration, but got reverted in commit ca13913aaf7e. For a good reason, the commit message mentions the same error which I got. So I think we should disable -Werror=implicit-function-declaration in xserver-xorg-video-nouveau for now until there is a fix in the xorg-server package. Cheers, Sven