Bug#1066292: createrepo-c: FTBFS: xml_file.c:338:36: error: implicit declaration of function ‘rasprintf’; did you mean ‘g_sprintf’? [-Werror=implicit-function-declaration]

[Michael Hudson-Doyle]

Package: createrepo-c
Followup-For: Bug #1066292
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch
X-Debbugs-Cc: michael.hud...@ubuntu.com
Control: tags -1 patch

Dear Maintainer,


In Ubuntu, the attached patch was applied to achieve the following:


  * Fix printing time_t and missing prototypes.


Thanks for considering the patch.


-- System Information:
Debian Release: trixie/sid
  APT prefers mantic-updates
  APT policy: (500, 'mantic-updates'), (500, 'mantic-security'), (500, 
'mantic'), (100, 'mantic-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.5.0-25-generic (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_NZ.UTF-8:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

diff -Nru createrepo-c-0.17.3/debian/patches/ftbfs.patch 
createrepo-c-0.17.3/debian/patches/ftbfs.patch
--- createrepo-c-0.17.3/debian/patches/ftbfs.patch      1970-01-01 
12:00:00.000000000 +1200
+++ createrepo-c-0.17.3/debian/patches/ftbfs.patch      2024-03-22 
15:53:53.000000000 +1300
@@ -0,0 +1,21 @@
+--- a/src/xml_dump_repomd.c
++++ b/src/xml_dump_repomd.c
+@@ -143,7 +143,7 @@
+                            BAD_CAST repomd->revision);
+     } else {
+         // Use the current time if no revision was explicitly specified
+-        gchar *rev = g_strdup_printf("%ld", time(NULL));
++        gchar *rev = g_strdup_printf("%lld", (long long)time(NULL));
+         xmlNewChild(root, NULL, BAD_CAST "revision", BAD_CAST rev);
+         g_free(rev);
+     }
+--- a/src/xml_file.c
++++ b/src/xml_file.c
+@@ -20,6 +20,7 @@
+ #include <glib.h>
+ #include <glib/gstdio.h>
+ #include <assert.h>
++#include <rpm/rpmstring.h>
+ #include "xml_file.h"
+ #include <errno.h>
+ #include "error.h"
diff -Nru createrepo-c-0.17.3/debian/patches/series 
createrepo-c-0.17.3/debian/patches/series
--- createrepo-c-0.17.3/debian/patches/series   2023-01-06 11:16:32.000000000 
+1300
+++ createrepo-c-0.17.3/debian/patches/series   2024-03-22 15:52:17.000000000 
+1300
@@ -1,3 +1,4 @@
 python-path.patch
 python-skbuild-path.patch
 python-platlib-debian.patch
+ftbfs.patch