Hi Ben, Thanks for thinking about dput.
(TBH, I don't use dput/dupload much since I use dgit) On Mon, 2024-04-08 at 07:46 +1000, Ben Finney wrote: > Control: severity -1 minor > Control: tags -1 - moreinfo > Control: merge 706607 -1 > > On 28-Aug-2016, Ben Finney wrote: > > > Is this behaviour the same problem reported in [bug#706607], or is that a > > separate problem? FYI: These 2 bug reports are not talking the same triggering conditions. But fix may be a single path since these are around the same message. So merging these are valid action :-) * https://bugs.debian.org/772204 * This is for security upload situation * Upload requires to have orig.tar.gz for all security uploads * Adjusting message is requested to be clear. * https://bugs.debian.org/706607#21 * This is for normal upload case. * Upload doesn't require to have orig.tar.gz for usual uploads. * Bug hits when used for derivative dists which uses -0 or similar as "revision" Here, "revision" means string matched for P<debian_version>. If I understand correctly, requiring orig.tar.gz upload for "revision" -1 is only for uploading to Debian repository. Ubuntu or other derivatives such as Kali start their "revision" from -0 or similar. 706607 talks interesting corner case for the upstream version which may contain "-" in it. 706607 talks valid phrase adjustment but that's not enough to address situation described in 772204. In light of these, I think following are needed. Action 1: * Fix REGEX to accommodate -0 variants and upstream version with "-". Action 2: * Adjust message to address rejection condition and repository policy I hope you addressed both pending actions. Regards, Osamu
