tags 595764 + patch thanks В 17:54 +0300 на 06.09.2010 (пн), Yavor Doganov написа: > identifying the upstream commit(s) that fix(es) this terminal.app bug > should be fairly trivial.
Indeed. Here it is.
>From 11cb95db7b69be2e60c559a507bc439cfc2dcfd4 Mon Sep 17 00:00:00 2001 From: Jeff Teunissen <d...@d2dc.net> Date: Wed, 13 May 2009 10:44:16 +0000 Subject: Terminal: fix character positioning Fix the character positioning, underlining, etc. Diff stolen from GAP, which in turn was based on a patch by Fred Kiefer. In any case, the display is not so screwed any more (though the wide char option seems badly broken). --- diff --git a/System/Applications/Terminal/TerminalView.m b/System/Applications/Terminal/TerminalView.m index e3ab4d7..74fac9e 100644 --- a/System/Applications/Terminal/TerminalView.m +++ b/System/Applications/Terminal/TerminalView.m @@ -2064,11 +2064,8 @@ improve? */ fx=s.width; fy=s.height; /* TODO: clear up font metrics issues with xlib/backart */ - fx0=fabs(r.origin.x); - if (r.origin.y<0) - fy0=fy+r.origin.y; - else - fy0=r.origin.y; + fx0=-r.origin.x; + fy0=-r.origin.y; NSDebugLLog(@"term",@"Bounding (%g %g)+(%g %g)",fx0,fy0,fx,fy); font_encoding=[font mostCompatibleStringEncoding]; boldFont_encoding=[boldFont mostCompatibleStringEncoding];
