On Sat, Feb 19, 2011 at 11:33:37AM -0500, Nathan A. Stine wrote:
> Package: synaptic
> Version: 0.75
> Severity: normal
> Tags: patch

Thanks for your bugreport and your patch.
 
> I have included a patch that should work well with all themes.  Instead of
> setting the background to a particular color during a search, the text and
> background colors are flip-flopped.

I played with the patch and after the first search I apparently get a
white background and white textcolor. So something is missing here,
could you please have a look? 


Thanks,
 Michael

> Best regards,
> 
> Nathan A. Stine
> 
> -- System Information:
> Debian Release: wheezy/sid
>   APT prefers unstable
>   APT policy: (500, 'unstable'), (1, 'experimental')
> Architecture: amd64 (x86_64)
> 
> Kernel: Linux 2.6.37-1-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/bash
> 
> Versions of packages synaptic depends on:
> ii  apt [libapt-pkg4.10]   0.8.11.5          Advanced front-end for dpkg
> ii  apt-utils [libapt-inst 0.8.11.5          APT utility programs
> ii  hicolor-icon-theme     0.12-1            default fallback theme for 
> FreeDes
> ii  libatk1.0-0            1.30.0-1          The ATK accessibility toolkit
> ii  libc6                  2.11.2-11         Embedded GNU C Library: Shared 
> lib
> ii  libcairo2              1.10.2-2          The Cairo 2D vector graphics 
> libra
> ii  libept1                1.0.4             High-level library for managing 
> De
> ii  libfontconfig1         2.8.0-2.1         generic font configuration 
> library
> ii  libfreetype6           2.4.2-2.1         FreeType 2 font engine, shared 
> lib
> ii  libgcc1                1:4.4.5-12        GCC support library
> ii  libglib2.0-0           2.28.0-2          The GLib library of C routines
> ii  libgtk2.0-0            2.20.1-2          The GTK+ graphical user 
> interface 
> ii  libpango1.0-0          1.28.3-1+squeeze1 Layout and rendering of 
> internatio
> ii  libstdc++6             4.4.5-12          The GNU Standard C++ Library v3
> ii  libvte9                1:0.24.3-2        Terminal emulator widget for 
> GTK+ 
> ii  libx11-6               2:1.4.1-4         X11 client-side library
> ii  libxapian22            1.2.4-1           Search engine library
> ii  zlib1g                 1:1.2.3.4.dfsg-3  compression library - runtime
> 
> Versions of packages synaptic recommends:
> ii  apt-xapian-index              0.41       maintenance and search tools for 
> a
> ii  gksu                          2.0.2-5    graphical frontend to su
> ii  libgtk2-perl                  2:1.222-1  Perl interface to the 2.x series 
> o
> ii  rarian-compat                 0.8.1-5    Documentation meta-data library 
> (c
> pn  software-properties-gtk       <none>     (no description available)
> 
> Versions of packages synaptic suggests:
> ii  deborphan                     1.7.28.3   program that can find unused 
> packa
> pn  dwww                          <none>     (no description available)
> ii  menu                          2.1.44     generates programs menu for all 
> me
> 
> -- no debconf information

> --- synaptic-0.75.orig/gtk/rgmainwindow.cc    2011-02-10 03:48:53.000000000 
> -0500
> +++ synaptic-0.75/gtk/rgmainwindow.cc 2011-02-19 11:07:10.171337400 -0500
> @@ -3048,10 +3048,12 @@
>        RGFlushInterface();
>        gtk_tree_view_set_model(GTK_TREE_VIEW(me->_treeView), NULL);
>        me->refreshTable();
> -      // set color to a light yellow to make it more obvious that a search
> -      // is performed
> -      GdkColor yellowish = {0, 63479,63479,48830};
> -      gtk_widget_modify_base(me->_entry_fast_search, GTK_STATE_NORMAL, 
> &yellowish);
> +      // allocate colors based on the current theme
> +      // flipping the text and the background on search should work ok
> +      GdkColor srchColorBox = 
> me->_entry_fast_search->style->text[GTK_STATE_NORMAL];
> +      GdkColor srchColorText = 
> me->_entry_fast_search->style->base[GTK_STATE_NORMAL];
> +      gtk_widget_modify_base(me->_entry_fast_search, GTK_STATE_NORMAL, 
> &srchColorBox);
> +      gtk_widget_modify_text(me->_entry_fast_search, GTK_STATE_NORMAL, 
> &srchColorText);
>     }
>     me->setBusyCursor(false);
>  




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to