Package: debhelper
Version: 8.1.6
Severity: minor
Tags: patch
Hi,
It seems like I made a small mistake in the dh_ucf postrm script that
results in unconditional use of ucf/ufcr. Although extremely unlikely
to occur in real setups, this is not OK.
Attached is a patch that addresses this and also adds quoting around
all config file arguments, in case they contain spaces.
Regards,
--
Jeroen Schot
>From 17603cd7ce7223e8e72771cd8c0202e38675eef2 Mon Sep 17 00:00:00 2001
From: Jeroen Schot <sc...@a-eskwadraat.nl>
Date: Tue, 23 Aug 2011 10:12:35 +0200
Subject: [PATCH] dh_ucf: fix test for ucf/ucfr availability and quote
filenames
---
autoscripts/postinst-ucf | 4 ++--
autoscripts/postrm-ucf | 10 +++++-----
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/autoscripts/postinst-ucf b/autoscripts/postinst-ucf
index 633d3ff..0546831 100644
--- a/autoscripts/postinst-ucf
+++ b/autoscripts/postinst-ucf
@@ -1,4 +1,4 @@
if [ "$1" = "configure" ]; then
- ucf #UCFSRC# #UCFDEST#
- ucfr #PACKAGE# #UCFDEST#
+ ucf "#UCFSRC#" "#UCFDEST#"
+ ucfr #PACKAGE# "#UCFDEST#"
fi
diff --git a/autoscripts/postrm-ucf b/autoscripts/postrm-ucf
index 5b0ef8b..da37572 100644
--- a/autoscripts/postrm-ucf
+++ b/autoscripts/postrm-ucf
@@ -1,12 +1,12 @@
if [ "$1" = "purge" ]; then
for ext in .ucf-new .ucf-old .ucf-dist ""; do
- rm -f #UCFDEST#$ext
+ rm -f "#UCFDEST#$ext"
done
- if [ -x `which ucf 2>/dev/null` ]; then
- ucf --purge #UCFDEST#
+ if [ -x "`which ucf 2>/dev/null`" ]; then
+ ucf --purge "#UCFDEST#"
fi
- if [ -x `which ucfr 2>/dev/null` ]; then
- ucfr --purge #PACKAGE# #UCFDEST#
+ if [ -x "`which ucfr 2>/dev/null`" ]; then
+ ucfr --purge #PACKAGE# "#UCFDEST#"
fi
fi
--
1.7.5.4
